Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.aresponses: 2.0.0 -> 2.1.0 #109427

Merged
merged 3 commits into from Jan 15, 2021
Merged

python3Packages.aresponses: 2.0.0 -> 2.1.0 #109427

merged 3 commits into from Jan 15, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 15, 2021

Motivation for this change

Update to latest upstream release 2.1.0

Change log: https://github.com/CircleUp/aresponses#210

Uses GitHub source now to be able to run the tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from makefu January 15, 2021 06:50
@fabaff
Copy link
Member Author

fabaff commented Jan 15, 2021

Successor of #107458

@fabaff
Copy link
Member Author

fabaff commented Jan 15, 2021

Failing tests in pyipp are exclude to make the build process pass.

Upstream issue: ctalkington/python-ipp#121

@fabaff
Copy link
Member Author

fabaff commented Jan 15, 2021

Result of nixpkgs-review pr 109427 run on x86_64-linux 1

19 packages built:
  • python37Packages.adguardhome
  • python37Packages.aresponses
  • python37Packages.pyairvisual
  • python37Packages.pyipp
  • python37Packages.pyiqvia
  • python37Packages.pytile
  • python37Packages.wled
  • python38Packages.adguardhome
  • python38Packages.aresponses
  • python38Packages.pyairvisual
  • python38Packages.pyhaversion
  • python38Packages.pyipp
  • python38Packages.pyiqvia
  • python38Packages.pytile
  • python38Packages.wled
  • python39Packages.adguardhome
  • python39Packages.aresponses
  • python39Packages.pyhaversion
  • python39Packages.pyipp

@fabaff fabaff mentioned this pull request Jan 15, 2021
Closed
@ofborg ofborg bot requested a review from mweinelt January 15, 2021 07:20
@mweinelt
Copy link
Member

mweinelt commented Jan 15, 2021 •
edited

I'm a bit surprised to see the pyipp change in this pull when there is otherwise no mention of it. Why is that?

ac8a17d

mweinelt
mweinelt approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

@mweinelt mweinelt merged commit 511b87c into NixOS:master Jan 15, 2021
@makefu
Copy link
Contributor

makefu commented Jan 15, 2021

Thanks for your work on this!

@fabaff fabaff deleted the bump-aresponses branch January 15, 2021 22:11
@fabaff fabaff mentioned this pull request Feb 4, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@makefu makefu Awaiting requested review from makefu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @mweinelt @makefu