Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openafs: 1.8.6 → 1.8.7 (emergency fix for unix timestamp 0x60000000) #109428

Merged
merged 1 commit into from Jan 15, 2021
Merged

openafs: 1.8.6 → 1.8.7 (emergency fix for unix timestamp 0x60000000) #109428

merged 1 commit into from Jan 15, 2021

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jan 15, 2021

Motivation for this change

This fixes a critical upstream issue with OpenAFS clients started after 14 Jan 2021 08:25:36 AM UTC (Unix epoch time 0x60000000). See https://lists.openafs.org/pipermail/openafs-announce/2021/000539.html.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
openafs: 1.8.6 → 1.8.7
175fdc8 
Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@rissson
Copy link
Member

rissson commented Jan 15, 2021

We should probably consider backporting this to 20.09.

@SuperSandro2000 SuperSandro2000 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 15, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 15, 2021

Result of nixpkgs-review pr 109428 run on x86_64-linux 1

12 packages marked as broken and skipped:
  • linuxPackages_hardened.openafs
  • linuxPackages_hardened.openafs_1_8
  • linuxPackages_hardkernel_4_14.openafs
  • linuxPackages_hardkernel_4_14.openafs_1_8
  • linuxPackages_hardkernel_latest.openafs
  • linuxPackages_hardkernel_latest.openafs_1_8
  • linuxPackages_latest_hardened.openafs
  • linuxPackages_latest_hardened.openafs_1_8
  • linuxPackages_latest_xen_dom0_hardened.openafs
  • linuxPackages_latest_xen_dom0_hardened.openafs_1_8
  • linuxPackages_xen_dom0_hardened.openafs
  • linuxPackages_xen_dom0_hardened.openafs_1_8
1 package failed to build:
  • linuxPackages-libre.openafs (linuxPackages-libre.openafs_1_8)
14 packages built:
  • linuxPackages.openafs (linuxPackages.openafs_1_8 ,linuxPackages_5_4.openafs ,linuxPackages_5_4.openafs_1_8)
  • linuxPackages_4_14.openafs (linuxPackages_4_14.openafs_1_8)
  • linuxPackages_4_19.openafs (linuxPackages_4_19.openafs_1_8)
  • linuxPackages_4_4.openafs (linuxPackages_4_4.openafs_1_8)
  • linuxPackages_4_9.openafs (linuxPackages_4_9.openafs_1_8)
  • linuxPackages_5_10.openafs (linuxPackages_5_10.openafs_1_8 ,linuxPackages_latest.openafs ,linuxPackages_latest.openafs_1_8)
  • linuxPackages_5_9.openafs (linuxPackages_5_9.openafs_1_8)
  • linuxPackages_latest-libre.openafs (linuxPackages_latest-libre.openafs_1_8)
  • linuxPackages_latest_xen_dom0.openafs (linuxPackages_latest_xen_dom0.openafs_1_8)
  • linuxPackages_lqx.openafs (linuxPackages_lqx.openafs_1_8)
  • linuxPackages_testing_bcachefs.openafs (linuxPackages_testing_bcachefs.openafs_1_8)
  • linuxPackages_xen_dom0.openafs (linuxPackages_xen_dom0.openafs_1_8)
  • linuxPackages_zen.openafs (linuxPackages_zen.openafs_1_8)
  • openafs (openafs_1_8)

@Mic92
Copy link
Member

Mic92 commented Jan 15, 2021

linux-libre is broke on its own. So this looks good to me.

@Mic92 Mic92 merged commit 94f3683 into NixOS:master Jan 15, 2021
@Mic92
Copy link
Member

Mic92 commented Jan 15, 2021

Backported however we use openafs 1.6 by default and 1.8 is a package user can choose instead. Can someone write an announcement to update to 1.8 on 20.09 or to make 1.8 default in 20.09?

@spacefrogg
Copy link
Contributor

Where would be a fitting place for such an announcement? Still the release notes?

@spacefrogg
Copy link
Contributor

Anyhow, openafs_1_6 is already marked broken in 20.09. So, the few users that still forced openafs_1_6 will be aware of immanent problems. So, I think we are all set up.

@erictapen
Copy link
Member

Backport in 3403628.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 15, 2021
@andersk andersk deleted the openafs-1.8.7 branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rissson rissson rissson approved these changes

Assignees
No one assigned
Labels
8.has: package (update) 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: nixpkgs-member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@andersk @rissson @Mic92 @spacefrogg @erictapen @SuperSandro2000