[TablesNG] fix block size distribution over empty rows #27204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2632154
branch
from
0828064
to
fd27fd8
Compare
Did not handle block size distribution over empty rows correctly. If there are empty constrained, and unconstrained rows, distribute only over unconstrained rows. We used to distribute over all empty rows. Row height distribution is tricky. There is no agreement between browsers on what the right thing to do is. FF never grows empty rows. Chrome does not distribute heights specified on TBODY. Bug: 1161157 Change-Id: I7cb2fb76ef4add651c61b10dbf8dd9fa0b58db0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632154 Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#845035}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2632154
branch
from
fd27fd8
to
76c046d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did not handle block size distribution over empty rows
correctly.
If there are empty constrained, and unconstrained rows,
distribute only over unconstrained rows.
We used to distribute over all empty rows.
Row height distribution is tricky. There is no agreement
between browsers on what the right thing to do is.
FF never grows empty rows. Chrome does not distribute
heights specified on TBODY.
Bug: 1161157
Change-Id: I7cb2fb76ef4add651c61b10dbf8dd9fa0b58db0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632154
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#845035}