Introduce Link.scopes for SubresourceWebBundles #27198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2021
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2615732
branch
2 times, most recently
from
1eddaba
to
7b576be
Compare
This CL introduces "scopes" attribute in <link> element for SubresourceWebBundles feature. https://github.com/WICG/webpackage/blob/master/explainers/subresource-loading.md#defining-the-scopes For example, if the following link tag exists in the page, <link rel="webbundle" href="https://example.com/dir/subresources.wbn" scopes="https://example.com/dir/js/ https://example.com/dir/img/ https://example.com/dir/css/"> subresources under "/dir/js/", "/dir/img/" and "/dir/css/" will be loaded from the web bundle "subresources.wbn". Bug: 1082020 Change-Id: I36ab832c301f33b0d0f1b6f4fea7e871f7ce2b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615732 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by: Hayato Ito <hayato@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843995}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2615732
branch
from
7b576be
to
fccdbb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL introduces "scopes" attribute in <link> element for
SubresourceWebBundles feature.
https://github.com/WICG/webpackage/blob/master/explainers/subresource-loading.md#defining-the-scopes
For example, if the following link tag exists in the page,
<link
rel="webbundle"
href="https://example.com/dir/subresources.wbn"
scopes="https://example.com/dir/js/
https://example.com/dir/img/
https://example.com/dir/css/">
subresources under "/dir/js/", "/dir/img/" and "/dir/css/" will be
loaded from the web bundle "subresources.wbn".
Bug: 1082020
Change-Id: I36ab832c301f33b0d0f1b6f4fea7e871f7ce2b83
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615732
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843995}