Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch: 0.3.1 -> 0.4.0 #109450

Merged
merged 1 commit into from Jan 15, 2021
Merged

nix-prefetch: 0.3.1 -> 0.4.0 #109450

merged 1 commit into from Jan 15, 2021

Conversation

msteen
Copy link
Contributor

@msteen msteen commented Jan 15, 2021 •
edited

Motivation for this change

Created a new release making the manual patching no longer necessary.

Changes in 0.4.0:

  • Experimental flake support.
  • Nix 2.4 support, including the new hash style.
  • Allow explicitly importing the nix-prefetch overlay when the ad-hoc approach fails.
  • Added Github Actions to run tests.
  • Add more fallbacks for XDG_RUNTIME_DIR.
  • Prevent retry loops when testing.
  • Workaround an incorrect exit code of nix.
  • Skip fetchFromGithub dummy in --list.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

There is no changelog.

@msteen
Copy link
Contributor Author

msteen commented Jan 15, 2021

@SuperSandro2000 I have added the changes under motivation for this change. I assume that is what you meant?

@thiagokokada
Copy link
Contributor

thiagokokada commented Jan 15, 2021 •
edited

Result of nixpkgs-review pr 109450 run on x86_64-linux 1

2 packages built:
  • nix-prefetch
  • nix-update

Seems to work well, tested both nix-prefetch and nix-update.

thiagokokada
thiagokokada reviewed Jan 15, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise LGTM, but please squash the commits.

@bbjubjub2494 bbjubjub2494 mentioned this pull request Jan 15, 2021
Closed
10 tasks
@SuperSandro2000
Copy link
Member

@SuperSandro2000 I have added the changes under motivation for this change. I assume that is what you meant?

I meant the downstream repo. It is missing the changelog for 4.0.

@SuperSandro2000 SuperSandro2000 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 15, 2021
SuperSandro2000
SuperSandro2000 approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged when ofborg is green

@msteen
Copy link
Contributor Author

msteen commented Jan 15, 2021

@thiagokokada Pity you cannot do that from Github, but managed to do it manually.

@SuperSandro2000 Where are you looking for the changelogs? I added them here:
https://github.com/msteen/nix-prefetch/blob/master/CHANGELOG.md#040

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109450 run on x86_64-darwin 1

1 package built:
  • nix-update

@SuperSandro2000 SuperSandro2000 merged commit f6a9596 into NixOS:master Jan 15, 2021
@msteen msteen deleted the patch-2 branch January 15, 2021 15:57
@erictapen
Copy link
Member

@SuperSandro2000 Could you elaborate on why this needs a backport?

@SuperSandro2000
Copy link
Member

I thought it was also broken on stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagokokada thiagokokada thiagokokada approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msteen @SuperSandro2000 @thiagokokada @erictapen