Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turbo-geth: 2020.12.02 -> 2021.01.01 #109449

Merged
merged 1 commit into from Jan 19, 2021

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented Jan 15, 2021

Motivation for this change

new version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109449 run on x86_64-darwin 1

1 package failed to build and are new build failure:
  • turbo-geth: log was empty

@d-xo
Copy link
Contributor Author

d-xo commented Jan 15, 2021

@SuperSandro2000 I don't understand whats going on with the build failure in your bot. This package builds fine for me locally:

$ git log -1
commit b44abca7216937cb6f7fcc11698346d3a6d9b083 (HEAD -> turbo-geth-2021.01.01, origin/turbo-geth-2021.01.01)
Author: David Terry <me@xwvvvvwx.com>
Date:   Fri Jan 15 15:00:21 2021 +0100

    turbo-geth: 2020.12.02 -> 2021.01.01

$ nix-build -A turbo-geth
/nix/store/1nmygjb164a3srvg9mj82r3m1m19awnj-turbo-geth-2021.01.01

$ ./result/bin/tg --version
tg version 2021.01.1-alpha

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 15, 2021

I don't understand whats going on with the build failure in your bot.

That is not a bot. It is just semi-automatic, not fully.

This package builds fine for me locally:

hash mismatch in fixed-output derivation '/nix/store/zxskryvm4s2gffnqmg97phvs23xba71k-source.drv':
  specified: sha256-Xt4YbvFb+izvWUS54sLmSCNKLV/l/midnzTM28uhHcQ=
     got:    sha256-mvYmzCY7Pmv7esJSm72tXTTQmkTiFGL+etZXBk4Bpyg=

I do not have the hash specified in your change so it tried to download the repo and got a different one.

@d-xo
Copy link
Contributor Author

d-xo commented Jan 18, 2021

Thanks for catching this, no idea how it happened. Perhaps the tag moved since I fetched it locally?

I updated the hash and force pushed.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109449 run on x86_64-linux 1

1 package built:
  • turbo-geth

@SuperSandro2000 SuperSandro2000 merged commit 7090164 into NixOS:master Jan 19, 2021
@d-xo d-xo deleted the turbo-geth-2021.01.01 branch January 19, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants