Feature: Allow GameScripts to add additional text to Industry view window #8576
+60
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
James103
reviewed
Jan 15, 2021
ldpl
force-pushed
the
industry-text
branch
2 times, most recently
from
1b700e8 to
6c42ea2
Compare
|
Note for |
michicc
reviewed
Jan 18, 2021
| SetControlFlags = 0, ///< Set IndustryControlFlags | ||
| SetExclusiveSupplier = 1, ///< Set exclusive supplier | ||
| SetExclusiveConsumer = 2, ///< Set exclusive consumer | ||
| SetText = 3, ///< Set additional text |
There was a problem hiding this comment.
Coding style for enum members:
LordAro: obviously it doesn't need the prefix, but yeah, should probably still be all caps
There was a problem hiding this comment.
Other 2 enum classes (ElementFloat and MidiSysexMessage) use this syntax. And IMO it's much nicer, as they are not in global namespace THERE IS NO NEED TO SHOUT :p
There was a problem hiding this comment.
Well, letting @LordAro have the last word here, but otherwise 👍
LordAro
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
With #8115 and #7912 been merged it becomes quite important for GameScripts to have the ability to communicate some extra info about specific industries to the player. This PR adds an additional text field to the industry that is shown at the bottom of the industry view window, much like it's already done for towns.
GS for testing:
industry-text-test.zip
Checklist for review