Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] sudo: 1.8.31p1 -> 1.9.5p1 #109433

Merged
merged 1 commit into from Jan 17, 2021
Merged

[20.09] sudo: 1.8.31p1 -> 1.9.5p1 #109433

merged 1 commit into from Jan 17, 2021

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 15, 2021

Motivation for this change

Backport needed for at least CVE-2021-23239. See #109082.

(cherry picked from commit ae6a8f9)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth @Ma27
sudo: 1.8.31p1 -> 1.9.5p1
518c381 
Backport needed for at least CVE-2021-23239.

(cherry picked from commit ae6a8f9)
@Ma27 Ma27 requested review from delroth and edolstra January 15, 2021 08:49
erictapen
erictapen approved these changes Jan 16, 2021
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this by building nixos/tests/sudo.nix.

@Ma27 Ma27 merged commit 3888fe8 into NixOS:release-20.09 Jan 17, 2021
@Ma27 Ma27 deleted the sudo branch January 17, 2021 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

@delroth delroth Awaiting requested review from delroth

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @erictapen @delroth