Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python37Packages.flake8-blind-except: 0.1.1 -> 0.2.0 #109464

Merged
merged 1 commit into from Jan 15, 2021
Merged

python37Packages.flake8-blind-except: 0.1.1 -> 0.2.0 #109464

merged 1 commit into from Jan 15, 2021

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for python37Packages.flake8-blind-except is: "A flake8 extension that checks for blind except: statements"

meta.homepage for python37Packages.flake8-blind-except is: "https://github.com/elijahandrews/flake8-blind-except"

meta.changelog for python37Packages.flake8-blind-except is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
Rebuild report (if merged into master) (click to expand) 
12 total rebuild path(s)

3 package rebuild(s)

3 x86_64-linux rebuild(s)
3 i686-linux rebuild(s)
3 x86_64-darwin rebuild(s)
3 aarch64-linux rebuild(s)


First fifty rebuilds by attrpath
python37Packages.flake8-blind-except
python38Packages.flake8-blind-except
python39Packages.flake8-blind-except
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/36jg8j9cpkm96zk11am4662l3khn9k7p-python3.7-flake8-blind-except-0.2.0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python37Packages.flake8-blind-except https://github.com/r-ryantm/nixpkgs/archive/209902517f81a562b1f71fcdd7d886a6c18fda0e.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/36jg8j9cpkm96zk11am4662l3khn9k7p-python3.7-flake8-blind-except-0.2.0
ls -la /nix/store/36jg8j9cpkm96zk11am4662l3khn9k7p-python3.7-flake8-blind-except-0.2.0/bin

Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package failed to build:
  • python39Packages.flake8-blind-except
2 packages built:
  • python37Packages.flake8-blind-except
  • python38Packages.flake8-blind-except
Maintainer pings

cc @johbo for testing.

@ofborg ofborg bot requested a review from johbo January 15, 2021 17:32
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109464 run on x86_64-darwin 1

3 packages built:
  • python37Packages.flake8-blind-except
  • python38Packages.flake8-blind-except
  • python39Packages.flake8-blind-except

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.flake8-blind-except:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python38Packages.flake8-blind-except:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.
python39Packages.flake8-blind-except:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;'and apythonImportsCheck`.

jonringer
jonringer approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 109464 run on x86_64-linux 1

3 packages built:
  • python37Packages.flake8-blind-except
  • python38Packages.flake8-blind-except
  • python39Packages.flake8-blind-except

@jonringer jonringer merged commit 8a31d15 into NixOS:master Jan 15, 2021
@r-ryantm r-ryantm deleted the auto-update/python3.7-flake8-blind-except branch January 16, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@johbo johbo Awaiting requested review from johbo

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r-ryantm @SuperSandro2000 @jonringer