Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fontforge: 20200314 -> 20201107 #109440

Merged
merged 1 commit into from Jan 23, 2021
Merged

fontforge: 20200314 -> 20201107 #109440

merged 1 commit into from Jan 23, 2021

Conversation

erictapen
Copy link
Member

Motivation for this change
Things done

Fontforge does have a huge amount of reverse dependencies, but the risk of breaking anything should be quite low, as it usually only generates font files.

I tested this by building fontforge fontforge-gtk fontforge-fonttools (against master though, current staging needs to rebuild lots of other stuff).

Also I checked, wether anything changes in the output of dejavu_fonts. Font files stay the same with the exception of share/fonts/truetype/DejaVuMathTeXGyre.ttf, which differs in large chunks. The new font looks good though, when viewed with gnome-font-viewer.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added this to WIP in Staging via automation Jan 17, 2021
@veprbl veprbl moved this from WIP to Ready in Staging Jan 17, 2021
@FRidh
Copy link
Member

FRidh commented Jan 22, 2021

merge conflict

@erictapen
fontforge: 20200314 -> 20201107
3cfebb9 
also use fetchFromGitHub for getting the source.
SuperSandro2000
SuperSandro2000 approved these changes Jan 23, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@erictapen erictapen merged commit a080091 into NixOS:staging Jan 23, 2021
Staging automation moved this from Ready to Done Jan 23, 2021
@erictapen erictapen mentioned this pull request Feb 7, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@nh2 nh2 Awaiting requested review from nh2

@dtzWill dtzWill Awaiting requested review from dtzWill

@alyssais alyssais Awaiting requested review from alyssais

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 2501-5000 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@erictapen @FRidh @SuperSandro2000