Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-language-server: do not propagate flake8 #109501

Merged
merged 2 commits into from Jan 27, 2021
Merged

python-language-server: do not propagate flake8 #109501

merged 2 commits into from Jan 27, 2021

Conversation

grwlf
Copy link
Contributor

@grwlf grwlf commented Jan 16, 2021 •
edited

python-language-server should not propagate flake8 because flake8 in turn propagates pyflakes. This has an effect of forcibly
enabling this checker despite its absence from providers.

Motivation for this change

Spurious error reports from python-language-server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

@grwlf please solve the merge conflict.

@ofborg ofborg bot requested a review from Mic92 January 18, 2021 22:15
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109501 run on x86_64-linux 1

3 packages failed to build and are new build failures:
10 packages built:
  • python37Packages.pyls-black
  • python37Packages.pyls-isort
  • python37Packages.pyls-mypy
  • python37Packages.pyls-spyder
  • python37Packages.python-language-server
  • python38Packages.pyls-black
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.pyls-spyder
  • python38Packages.python-language-server

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.spyder:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'jedi==0.17.1' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

spyder:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'jedi==0.17.1' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

@SuperSandro2000
Copy link
Member

@grwlf can you do me a favor and add flake8 to spyder to fix the regression?

@grwlf grwlf force-pushed the pyls-no-pyflakes-leak branch 3 times, most recently from 9de071b to bc4b9ca Compare January 27, 2021 17:52
@grwlf
python-language-server: do not propagate flake8
24a4bbf 
Because flake8 in turn propagates pyflakes. This effectively forcibly
enables this checker enabled even if user doesn't want it.
@ofborg ofborg bot requested review from gebner and Mic92 January 27, 2021 18:02
@grwlf
spyder: add explicit dependency on flake8
4d2f81c 
Previously it used flake8 from python-language-server implicitly
@ofborg ofborg bot requested a review from Mic92 January 27, 2021 19:04
@Mic92
Copy link
Member

Mic92 commented Jan 27, 2021

Result of nixpkgs-review pr 109501 run on x86_64-linux 1

12 packages built:
  • python37Packages.pyls-black
  • python37Packages.pyls-isort
  • python37Packages.pyls-mypy
  • python37Packages.pyls-spyder
  • python37Packages.python-language-server
  • python37Packages.spyder
  • python38Packages.pyls-black
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.pyls-spyder
  • python38Packages.python-language-server
  • spyder (python38Packages.spyder)

@Mic92 Mic92 merged commit 6834d03 into NixOS:master Jan 27, 2021
@grwlf grwlf deleted the pyls-no-pyflakes-leak branch January 27, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@gebner gebner Awaiting requested review from gebner

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@grwlf @SuperSandro2000 @Mic92