Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.{mocket,samsunsgtvws,segments,csvw}: update #109515

Merged
merged 4 commits into from Jan 19, 2021
Merged

python3Packages.{mocket,samsunsgtvws,segments,csvw}: update #109515

merged 4 commits into from Jan 19, 2021

Conversation

mweinelt
Copy link
Member

Motivation for this change
Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt
Copy link
Member Author

mweinelt commented Jan 16, 2021 •
edited

Result of nixpkgs-review pr 109515 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.geoip2
  • python39Packages.sopel
1 package failed to build:
  • tts
22 packages built:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.geoip2
  • python37Packages.mocket
  • python37Packages.phonemizer
  • python37Packages.samsungtvws
  • python37Packages.segments
  • python37Packages.sopel
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.geoip2
  • python38Packages.mocket
  • python38Packages.phonemizer
  • python38Packages.samsungtvws
  • python38Packages.segments
  • python38Packages.sopel
  • python39Packages.clldutils
  • python39Packages.csvw
  • python39Packages.mocket
  • python39Packages.phonemizer
  • python39Packages.samsungtvws
  • python39Packages.segments

The tts test is broken on target branch.

@mweinelt mweinelt marked this pull request as draft January 16, 2021 12:34
@mweinelt
Copy link
Member Author

Trying to get the mocket tests running, bear with me.

@mweinelt mweinelt changed the title Python updates python3Packages.{mocket,samsunsgtvws,segments,csvw} Jan 16, 2021
@mweinelt mweinelt changed the title python3Packages.{mocket,samsunsgtvws,segments,csvw} python3Packages.{mocket,samsunsgtvws,segments,csvw: update Jan 16, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109515 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.geoip2
  • python39Packages.sopel
22 packages built:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.geoip2
  • python37Packages.mocket
  • python37Packages.phonemizer
  • python37Packages.samsungtvws
  • python37Packages.segments
  • python37Packages.sopel
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.geoip2
  • python38Packages.mocket
  • python38Packages.phonemizer
  • python38Packages.samsungtvws
  • python38Packages.segments
  • python38Packages.sopel
  • python39Packages.clldutils
  • python39Packages.csvw
  • python39Packages.mocket
  • python39Packages.phonemizer
  • python39Packages.samsungtvws
  • python39Packages.segments

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109515 run on x86_64-darwin 1

2 packages marked as broken and skipped:
  • python39Packages.geoip2
  • python39Packages.sopel
22 packages built:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.geoip2
  • python37Packages.mocket
  • python37Packages.phonemizer
  • python37Packages.samsungtvws
  • python37Packages.segments
  • python37Packages.sopel
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.geoip2
  • python38Packages.mocket
  • python38Packages.phonemizer
  • python38Packages.samsungtvws
  • python38Packages.segments
  • python38Packages.sopel
  • python39Packages.clldutils
  • python39Packages.csvw
  • python39Packages.mocket
  • python39Packages.phonemizer
  • python39Packages.samsungtvws
  • python39Packages.segments

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.mocket:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'setup_requires=["pipenv"]' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python37Packages.samsungtvws:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'websocket-client==' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.mocket:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'setup_requires=["pipenv"]' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.samsungtvws:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'websocket-client==' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.mocket:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'setup_requires=["pipenv"]' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.samsungtvws:

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'websocket-client==' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

@mweinelt mweinelt changed the title python3Packages.{mocket,samsunsgtvws,segments,csvw: update python3Packages.{mocket,samsunsgtvws,segments,csvw}: update Jan 18, 2021
@mweinelt mweinelt marked this pull request as ready for review January 18, 2021 08:15
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109515 run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python39Packages.geoip2
  • python39Packages.sopel
3 packages failed to build and are new build failures:
  • python37Packages.geoip2: log was empty
  • python37Packages.mocket: log https://termbin.com/u8imo
  • python37Packages.sopel: log was empty
19 packages built:
  • python37Packages.clldutils
  • python37Packages.csvw
  • python37Packages.phonemizer
  • python37Packages.samsungtvws
  • python37Packages.segments
  • python38Packages.clldutils
  • python38Packages.csvw
  • python38Packages.geoip2
  • python38Packages.mocket
  • python38Packages.phonemizer
  • python38Packages.samsungtvws
  • python38Packages.segments
  • python38Packages.sopel
  • python39Packages.clldutils
  • python39Packages.csvw
  • python39Packages.mocket
  • python39Packages.phonemizer
  • python39Packages.samsungtvws
  • python39Packages.segments

@mweinelt
Copy link
Member Author

class unittest.IsolatedAsyncioTestCase(methodName='runTest')

This class provides an API similar to TestCase and also accepts coroutines as test functions.

New in version 3.8.

Aha, fixed by ignoring tests38 on pythonOlder 3.8.

jonringer
jonringer approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/109515

2 packages marked as broken and skipped:
python39Packages.geoip2 python39Packages.sopel

1 package failed to build:
tts

22 packages built:
python37Packages.clldutils python37Packages.csvw python37Packages.geoip2 python37Packages.mocket python37Packages.phonemizer python37Packages.samsungtvws python37Packages.segments python37Packages.sopel python38Packages.clldutils python38Packages.csvw python38Packages.geoip2 python38Packages.mocket python38Packages.phonemizer python38Packages.samsungtvws python38Packages.segments python38Packages.sopel python39Packages.clldutils python39Packages.csvw python39Packages.mocket python39Packages.phonemizer python39Packages.samsungtvws python39Packages.segments

@jonringer jonringer merged commit a6b7d68 into NixOS:master Jan 19, 2021
@mweinelt mweinelt deleted the python-updates branch January 19, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mweinelt @SuperSandro2000 @jonringer