Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: 1.34.0 -> 1.34.1 #109513

Merged
merged 2 commits into from Jan 16, 2021
Merged

grpc: 1.34.0 -> 1.34.1 #109513

merged 2 commits into from Jan 16, 2021

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jan 16, 2021

Motivation for this change

https://github.com/grpc/grpc/releases/tag/v1.34.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from LnL7 January 16, 2021 12:07
@marsam
Copy link
Contributor Author

marsam commented Jan 16, 2021

@GrahamcOfBorg build python3Packages.grpcio python3Packages.grpcio-tools

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109513 run on x86_64-linux 1

2 packages built:
  • python3Packages.grpcio
  • python3Packages.grpcio-tools

@marsam marsam merged commit e1545d4 into NixOS:master Jan 16, 2021
@marsam marsam deleted the update-grpc branch January 16, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @SuperSandro2000