Stop-color, flood-color, and lighting-color in forced colors mode #27206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jan 15, 2021
When investigating CL:2627779, I had noticed a few other color properties we weren't adjusting for in forced colors mode: stop-color, flood-color, and lighting-color. In most cases, this shouldn't make a difference since SVG elements are set to 'forced-color-adjust: none' by default, but I figured these would be good to include for consistency. Bug: 1166911 Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845474}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2633944
branch
from
b1b5857
to
c1b1ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When investigating CL:2627779, I had noticed a few other color
properties we weren't adjusting for in forced colors mode:
stop-color, flood-color, and lighting-color. In most cases, this
shouldn't make a difference since SVG elements are set to
'forced-color-adjust: none' by default, but I figured these would
be good to include for consistency.
Bug: 1166911
Change-Id: I47d16b20309565d28e24e1410115b5a36f22a662
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633944
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845474}