Skip to content

python3Packages.aiocoap: init at 0.4b3 #109482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2021
Merged

python3Packages.aiocoap: init at 0.4b3 #109482

merged 1 commit into from
Jan 29, 2021
+33 −0

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 15, 2021

Motivation for this change

Python CoAP library

https://aiocoap.readthedocs.io/

This is a dependency of pytradfri which is a Home Assistant dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@fabaff fabaff force-pushed the aiocoap branch 2 times, most recently from 923cd7c to 8f49269 Compare January 15, 2021 23:04
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Jan 15, 2021
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109482 run on x86_64-linux 1

1 package marked as broken and skipped:
  • python39Packages.aiocoap
5 packages built:
  • python37Packages.aiocoap
  • python37Packages.linkheader
  • python38Packages.aiocoap
  • python38Packages.linkheader
  • python39Packages.linkheader

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 16, 2021 •
edited
Loading

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109482 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.aiocoap
2 packages failed to build and are new build failures:
3 packages built:
  • python37Packages.linkheader
  • python38Packages.linkheader
  • python39Packages.linkheader

Darwin fails because of sandbox.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109482 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.aiocoap
2 packages failed to build and are new build failures:
3 packages built:
  • python37Packages.linkheader
  • python38Packages.linkheader
  • python39Packages.linkheader

jonringer
jonringer reviewed Jan 22, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aiocap seems like a well maintained library, but I just don't really like having "obsolete" libraries being trickled in with decent ones.

New python interpreters will generally introduce breaking changes and have unmaintained libraries makes the process a lot more difficult

@fabaff
python3Packages.aiocoap: init at 0.4b3

Verified

This commit was signed with the committer’s verified signature.
primeos Michael Weiss
GPG key ID: 5BE487C4D4771D83
Verified
Learn about vigilant mode
cd6aa10
@fabaff
Copy link
Member Author

fabaff commented Jan 29, 2021

Result of nixpkgs-review pr 109482 run on x86_64-linux 1

3 packages built:
  • python37Packages.aiocoap
  • python38Packages.aiocoap
  • python39Packages.aiocoap

@mweinelt mweinelt merged commit b1280aa into NixOS:master Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@mweinelt mweinelt

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fabaff @SuperSandro2000 @mweinelt @jonringer