Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.graphviz: 0.14.1 -> 0.16 #109507

Merged
merged 3 commits into from Jan 20, 2021
Merged

pythonPackages.graphviz: 0.14.1 -> 0.16 #109507

merged 3 commits into from Jan 20, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 16, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the PR title and commit message to pythonPackages.graphviz: 0.14.1 -> 0.16? It is more common and easily searchable.

@dotlambda dotlambda changed the title python.pkgs.graphviz: 0.14.1 -> 0.16 pythonPackages.graphviz: 0.14.1 -> 0.16 Jan 16, 2021
@dotlambda
Copy link
Member Author

@SuperSandro2000 I think this is ready to be merged.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109507 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • pepper
  • python37Packages.optuna
  • python38Packages.optuna
  • python39Packages.pyalgotrade
  • python39Packages.pyro-ppl
4 packages failed to build and are new build failures:
  • python37Packages.dask-xgboost: log was empty
  • python37Packages.xgboost: log was empty
  • python38Packages.dask-xgboost: log was empty
  • python38Packages.xgboost: log was empty
52 packages built:
  • beets
  • flexget
  • mnemosyne
  • python37Packages.WSME
  • python37Packages.cherrypy
  • python37Packages.graphviz
  • python37Packages.heudiconv
  • python37Packages.ibis-framework
  • python37Packages.mxnet
  • python37Packages.nipype
  • python37Packages.objgraph
  • python37Packages.prov
  • python37Packages.pyalgotrade
  • python37Packages.pydotplus
  • python37Packages.pyro-ppl
  • python37Packages.pysonos
  • python37Packages.skidl
  • python37Packages.soco
  • python37Packages.streamz
  • python37Packages.ws4py
  • python37Packages.xdot
  • python37Packages.zerobin
  • python38Packages.WSME
  • python38Packages.cherrypy
  • python38Packages.graphviz
  • python38Packages.mxnet
  • python38Packages.nipype
  • python38Packages.objgraph
  • python38Packages.prov
  • python38Packages.pyalgotrade
  • python38Packages.pydotplus
  • python38Packages.pyro-ppl
  • python38Packages.pysonos
  • python38Packages.skidl
  • python38Packages.soco
  • python38Packages.streamz
  • python38Packages.ws4py
  • xdot (python38Packages.xdot)
  • python38Packages.zerobin
  • python39Packages.cherrypy
  • python39Packages.graphviz
  • python39Packages.mxnet
  • python39Packages.objgraph
  • python39Packages.prov
  • python39Packages.pydotplus
  • python39Packages.skidl
  • python39Packages.soco
  • python39Packages.ws4py
  • python39Packages.xdot
  • python39Packages.zerobin
  • sabnzbd
  • tribler

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

python37Packages.mxnet:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'numpy<=1.15.2,' doesn't match anything in file 'python/setup.py'
substituteStream(): WARNING: pattern 'requests<2.19.0,' doesn't match anything in file 'python/setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python37Packages.prov:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'six==1.10.0' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python37Packages.pydotplus:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python38Packages.mxnet:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'numpy<=1.15.2,' doesn't match anything in file 'python/setup.py'
substituteStream(): WARNING: pattern 'requests<2.19.0,' doesn't match anything in file 'python/setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.prov:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'six==1.10.0' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python38Packages.pydotplus:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.
python39Packages.mxnet:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'numpy<=1.15.2,' doesn't match anything in file 'python/setup.py'
substituteStream(): WARNING: pattern 'requests<2.19.0,' doesn't match anything in file 'python/setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.prov:

Please consider this feature to be alpha.

A substituteInPlace with an unused --replace got detected:

substituteStream(): WARNING: pattern 'six==1.10.0' doesn't match anything in file 'setup.py'

Please check the offending substituteInPlace for typos or changes in source.

python39Packages.pydotplus:

Zero tests run by pytest got detected: 'Ran 0 tests in 0.000s'
You have the following options to fix this:

  • Tell pytest(CheckHook) where to find the tests included in the package
  • Check if the GitHub Repo contains tests but they are not shipped with Pypi. If so please switch to fetchFromGitHub.
  • If the Packages does not contain any tests add 'doCheck = false;' and a pythonImportsCheck.

@dotlambda
Copy link
Member Author

cc @abbradar regarding the useless substituteInPlace in pythonPackages.mxnet. You could file an issue upstream to loosen the bound on the remaining graphviz.

@dotlambda
Copy link
Member Author

I think it's a good idea to drop pythonPackages.pydotplus since pythonPackages.pydot is a maintained drop-in replacement.

@ofborg ofborg bot requested a review from ashgillman January 18, 2021 22:46
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109507 run on x86_64-darwin 1

3 packages marked as broken and skipped:
  • pepper
  • python39Packages.pyalgotrade
  • python39Packages.pyro-ppl
1 package failed to build and already failed to build on hydra master:
  • mnemosyne: log was empty
48 packages failed to build and are new build failures:
  • flexget: log was empty
  • python37Packages.WSME: log was empty
  • python37Packages.cherrypy: log was empty
  • python37Packages.dask-xgboost: log was empty
  • python37Packages.graphviz: log https://termbin.com/omdk
  • python37Packages.heudiconv: log was empty
  • python37Packages.ibis-framework: log was empty
  • python37Packages.nipype: log was empty
  • python37Packages.objgraph: log was empty
  • python37Packages.prov: log https://termbin.com/9jbl
  • python37Packages.pyalgotrade: log was empty
  • python37Packages.pyro-ppl: log was empty
  • python37Packages.pysonos: log was empty
  • python37Packages.skidl: log was empty
  • python37Packages.soco: log was empty
  • python37Packages.streamz: log was empty
  • python37Packages.ws4py: log was empty
  • python37Packages.xdot: log was empty
  • python37Packages.xgboost: log was empty
  • python37Packages.zerobin: log was empty
  • python38Packages.WSME: log was empty
  • python38Packages.cherrypy: log was empty
  • python38Packages.dask-xgboost: log was empty
  • python38Packages.graphviz: log https://termbin.com/13c1j
  • python38Packages.nipype: log was empty
  • python38Packages.objgraph: log was empty
  • python38Packages.prov: log https://termbin.com/mvjt
  • python38Packages.pyalgotrade: log was empty
  • python38Packages.pyro-ppl: log was empty
  • python38Packages.pysonos: log was empty
  • python38Packages.skidl: log was empty
  • python38Packages.soco: log was empty
  • python38Packages.streamz: log was empty
  • python38Packages.ws4py: log was empty
  • xdot: log was empty
  • (python38Packages.xdot): log was empty
  • python38Packages.xgboost: log was empty
  • python38Packages.zerobin: log was empty
  • python39Packages.cherrypy: log was empty
  • python39Packages.graphviz: log https://termbin.com/i0si
  • python39Packages.nipype: log was empty
  • python39Packages.objgraph: log was empty
  • python39Packages.prov: log https://termbin.com/esuf
  • python39Packages.skidl: log was empty
  • python39Packages.soco: log was empty
  • python39Packages.ws4py: log was empty
  • python39Packages.xdot: log was empty
  • python39Packages.zerobin: log was empty

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109507 run on x86_64-linux 1

5 packages marked as broken and skipped:
  • pepper
  • python37Packages.optuna
  • python38Packages.optuna
  • python39Packages.pyalgotrade
  • python39Packages.pyro-ppl
4 packages failed to build and are new build failures:
  • python37Packages.dask-xgboost: log was empty
  • python37Packages.xgboost: log was empty
  • python38Packages.dask-xgboost: log was empty
  • python38Packages.xgboost: log was empty
49 packages built:
  • beets
  • flexget
  • mnemosyne
  • python37Packages.WSME
  • python37Packages.cherrypy
  • python37Packages.graphviz
  • python37Packages.heudiconv
  • python37Packages.ibis-framework
  • python37Packages.mxnet
  • python37Packages.nipype
  • python37Packages.objgraph
  • python37Packages.prov
  • python37Packages.pyalgotrade
  • python37Packages.pyro-ppl
  • python37Packages.pysonos
  • python37Packages.skidl
  • python37Packages.soco
  • python37Packages.streamz
  • python37Packages.ws4py
  • python37Packages.xdot
  • python37Packages.zerobin
  • python38Packages.WSME
  • python38Packages.cherrypy
  • python38Packages.graphviz
  • python38Packages.mxnet
  • python38Packages.nipype
  • python38Packages.objgraph
  • python38Packages.prov
  • python38Packages.pyalgotrade
  • python38Packages.pyro-ppl
  • python38Packages.pysonos
  • python38Packages.skidl
  • python38Packages.soco
  • python38Packages.streamz
  • python38Packages.ws4py
  • xdot (python38Packages.xdot)
  • python38Packages.zerobin
  • python39Packages.cherrypy
  • python39Packages.graphviz
  • python39Packages.mxnet
  • python39Packages.objgraph
  • python39Packages.prov
  • python39Packages.skidl
  • python39Packages.soco
  • python39Packages.ws4py
  • python39Packages.xdot
  • python39Packages.zerobin
  • sabnzbd
  • tribler

ashgillman
ashgillman approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@ashgillman ashgillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Pydotplus is no longer used by prov or anywhere else, and pydot, I think, is being maintained again so no need for the former.

@dotlambda dotlambda merged commit a824dc6 into NixOS:master Jan 20, 2021
@dotlambda dotlambda deleted the python-graphviz-0.16 branch January 20, 2021 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@ashgillman ashgillman ashgillman approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @SuperSandro2000 @ashgillman