Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytz: 2020.04 -> 2020.05 #109510

Merged
merged 1 commit into from Feb 1, 2021
Merged

pythonPackages.pytz: 2020.04 -> 2020.05 #109510

merged 1 commit into from Feb 1, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh January 16, 2021 10:17
@SuperSandro2000 SuperSandro2000 changed the title python.pkgs.pytz: 2020.04 -> 2020.05 pythonPackages.pytz: 2020.04 -> 2020.05 Jan 16, 2021
@SuperSandro2000
Copy link
Member

/rebase-staging

SuperSandro2000
SuperSandro2000 reviewed Jan 16, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could first fetch the rebased on staging branch and then change the commit message to pythonPackages.pytz: 2020.04 -> 2020.05. It is more common and easily searchable.

@github-actions
Copy link
Contributor

Failed to rebase on staging

@dotlambda dotlambda changed the title pythonPackages.pytz: 2020.04 -> 2020.05 [WIP] pythonPackages.pytz: 2020.04 -> 2020.05 Jan 16, 2021
@dotlambda

This comment has been minimized.

Sign in to view
@dotlambda dotlambda changed the base branch from master to staging January 23, 2021 14:29
@dotlambda dotlambda changed the title [WIP] pythonPackages.pytz: 2020.04 -> 2020.05 pythonPackages.pytz: 2020.04 -> 2020.05 Jan 23, 2021
@dotlambda
Copy link
Member Author

@jonringer ping

@dotlambda dotlambda merged commit b97fca2 into NixOS:staging Feb 1, 2021
dasj19 pushed a commit to dasj19/nixpkgs that referenced this pull request Feb 11, 2021
@dotlambda @dasj19
pythonPackages.pytz: 2020.04 -> 2020.05 (NixOS#109510)
9607e42
@dotlambda dotlambda deleted the pytz-2020.05 branch January 17, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dotlambda @SuperSandro2000