Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.transformers: 4.1.1 -> 4.2.2 #109505

Merged
merged 3 commits into from Jan 23, 2021
Merged

python3Packages.transformers: 4.1.1 -> 4.2.2 #109505

merged 3 commits into from Jan 23, 2021

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:
https://github.com/huggingface/transformers/releases/tag/v4.2.0
https://github.com/huggingface/transformers/releases/tag/v4.2.1

Changes to the derivation:

  • Enable on Python 3.9.
  • Disable checks and use pythonImportsCheck instead. The list of
    excluded tests was getting silly. The vast majority of tests
    require internet access (to download models). I guess at this
    point we just have to accept that it is not practical to run
    the tests.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pashashocky January 16, 2021 10:15
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109505 run on x86_64-darwin 1

3 packages failed to build and are new build failures:
  • python37Packages.transformers: log https://termbin.com/tfq0
  • python38Packages.transformers: log was empty
  • python39Packages.transformers: log was empty

@danieldk
python3Packages.transformers: 4.1.1 -> 4.2.1
483ce5c 
Changelog:
https://github.com/huggingface/transformers/releases/tag/v4.2.0
https://github.com/huggingface/transformers/releases/tag/v4.2.1

Changes to the derivation:

- Enable on Python 3.9.
- Disable checks and use pythonImportsCheck instead. The list of
  excluded tests was getting silly. The vast majority of tests
  require internet access (to download models). I guess at this
  point we just have to accept that it is not practical to run
  the tests.
@danieldk
Copy link
Contributor Author

@SuperSandro2000 thanks! Python 3.7 should be fixed now, 3.8 and 3.9 build fine here.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109505 run on x86_64-linux 1

1 package failed to build and are new build failure:
2 packages built:
  • python38Packages.transformers
  • python39Packages.transformers

@danieldk
Copy link
Contributor Author

@ofborg build python37Packages.transformers python38Packages.transformers python39Packages.transformers

@danieldk
Copy link
Contributor Author

@SuperSandro2000 cannot reproduce locally and ofborg is also happy.

@danieldk danieldk changed the title python3Packages.transformers: 4.1.1 -> 4.2.1 python3Packages.transformers: 4.1.1 -> 4.2.2 Jan 23, 2021
@danieldk danieldk mentioned this pull request Jan 23, 2021
Merged
10 tasks
@symphorien symphorien merged commit 5f92e69 into NixOS:master Jan 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@pashashocky pashashocky Awaiting requested review from pashashocky

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @SuperSandro2000 @symphorien