Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add Universal description for modern macOS binaries #182

Merged
merged 1 commit into from Jan 16, 2021

Conversation

orudge
Copy link
Contributor

@orudge orudge commented Jan 16, 2021

Refer to "macOS" and label the binaries as universal.

@@ -200,6 +200,8 @@ linux-ubuntu-xenial-i386-dbg.deb:
description: Debug Symbols for Linux Ubuntu Xenial 16.04 (i386, 32 bit)
linux-ubuntu-xenial-i386.deb:
description: Linux Ubuntu Xenial 16.04 (i386, 32 bit)
macos-universal.dmg:
description: macOS 10.9+ (Universal)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is mentioning "Universal" clear enough for people? I kinda miss the mention it is Intel and Arm/Silicon, as universal could be all kinds of combinations. I don't know what other software does, but if I bought an M1, not sure that Universal gave me the idea that it would run native, as I would be thinking: no way they ported their software this quick :P

I don't know the MacOS world enough, just asking the question :D

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The binary shows up as "Universal", "Intel" or "Apple Silicon" in the Mac's Get Info dialog, so this is consistent with Apple's usage. I don't think it would cause confusion.

The old (PPC/Intel) Universal binaries haven't really been around for a decade or so.

TrueBrain
TrueBrain previously approved these changes Jan 16, 2021
@orudge orudge merged commit 39fe8f9 into OpenTTD:master Jan 16, 2021
@orudge orudge deleted the macos-description branch January 16, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants