Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.lima: init at 0.5 #109506

Closed
wants to merge 2 commits into from
Closed

python3Packages.lima: init at 0.5 #109506

wants to merge 2 commits into from

Conversation

zhaofengli
Copy link
Member

Motivation for this change

Lima is a Python library that converts Python objects to native data structures.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@zhaofengli zhaofengli force-pushed the python-lima branch 2 times, most recently from 99ec273 to be2d8fc Compare January 16, 2021 10:36
@SuperSandro2000
Copy link
Member

You messed something up while rebasing. Please drop the extra commits.

@zhaofengli
Copy link
Member Author

By the way, I'm planning to add a few more Python dependencies for powerdns-admin. Should I create separate PRs for each of them including powerdns-admin itself, or can I batch them into one PR?

@SuperSandro2000
Copy link
Member

Should I create separate PRs for each of them including powerdns-admin itself, or can I batch them into one PR?

If they are all required for powerdns-admin and are pretty simple than you can put them into the PR of powerdns-admin. If there are more complicated ones then the merge could be a bit delayed because we need to review all of them. We can always split something out if the PR grows to big.

@zhaofengli
Copy link
Member Author

Opening a new PR for powerdns-admin along with all missing dependencies.

@zhaofengli zhaofengli closed this Jan 18, 2021
@zhaofengli zhaofengli deleted the python-lima branch June 12, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhaofengli @SuperSandro2000