Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aliza: 1.98.32 -> 1.98.43 #109476

Merged
merged 1 commit into from Feb 21, 2021
Merged

aliza: 1.98.32 -> 1.98.43 #109476

merged 1 commit into from Feb 21, 2021

Conversation

CRTified
Copy link
Contributor

@CRTified CRTified commented Jan 15, 2021 •
edited

Motivation for this change

Old download link was dead, so I had to bump it to get it working.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Jan 15, 2021 •
edited

Can we put the download url onto web.archive.org?

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109476 run on x86_64-linux 1

1 package built:
  • aliza

@CRTified
Copy link
Contributor Author

Can we put the download url onto web.archive.org?

That might make sense, given that they seem to regularly drop old links. I've also found this repository, but the version numbers don't line up. Hard to tell the exact state of this software. Screenshot section visible there looks like the application I used today, and the GPLv3 license would be nicer to utilize, I think.

I'm also by no means a regular user, I just found some DICOM files today and wanted to have a look at them. Found aliza as a viewing software, and as the download failed, I fixed it and created this PR, as it was a rather simple PR.

Also pinging @Mounium as maintainer.

@davidak davidak merged commit c7c0037 into NixOS:master Feb 21, 2021
LeSuisse referenced this pull request Jun 13, 2021
@LeSuisse
aliza: update source URL
e4da730 
The existing URL to download from Google Drive seems to fail now (we get
a HTML page with a warning about the content instead).

Closes #126508
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidak davidak davidak approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CRTified @SuperSandro2000 @davidak