Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.azure*: bump #109473

Merged
merged 8 commits into from Jan 16, 2021
Merged

python3Packages.azure*: bump #109473

merged 8 commits into from Jan 16, 2021

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 15, 2021 •
edited

Motivation for this change

closes: #109467
closes: #109468

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh as a code owner January 15, 2021 20:03
@jonringer jonringer changed the title Bump azure again python3Packages.azure*: bump Jan 15, 2021
@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/109473

20 packages built:
appdaemon azure-cli dvc-with-remotes python37Packages.azure-mgmt-loganalytics python37Packages.azure-mgmt-monitor python37Packages.azure-servicebus python37Packages.azure-storage-blob python37Packages.azure-storage-file-share python37Packages.snowflake-connector-python python37Packages.snowflake-sqlalchemy python37Packages.uamqp python38Packages.azure-mgmt-loganalytics python38Packages.azure-mgmt-monitor python38Packages.azure-servicebus python38Packages.azure-storage-blob python38Packages.azure-storage-file-share python38Packages.snowflake-connector-python python38Packages.snowflake-sqlalchemy python38Packages.uamqp python39Packages.uamqp

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109473 run on x86_64-linux 1

20 packages built:
  • appdaemon
  • azure-cli
  • dvc-with-remotes
  • python37Packages.azure-mgmt-loganalytics
  • python37Packages.azure-mgmt-monitor
  • python37Packages.azure-servicebus
  • python37Packages.azure-storage-blob
  • python37Packages.azure-storage-file-share
  • python37Packages.snowflake-connector-python
  • python37Packages.snowflake-sqlalchemy
  • python37Packages.uamqp
  • python38Packages.azure-mgmt-loganalytics
  • python38Packages.azure-mgmt-monitor
  • python38Packages.azure-servicebus
  • python38Packages.azure-storage-blob
  • python38Packages.azure-storage-file-share
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy
  • python38Packages.uamqp
  • python39Packages.uamqp

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109473 run on x86_64-darwin 1

7 packages marked as broken and skipped:
  • python39Packages.azure-mgmt-loganalytics
  • python39Packages.azure-mgmt-monitor
  • python39Packages.azure-servicebus
  • python39Packages.azure-storage-blob
  • python39Packages.azure-storage-file-share
  • python39Packages.snowflake-connector-python
  • python39Packages.snowflake-sqlalchemy
5 packages failed to build and are new build failures:
15 packages built:
  • appdaemon
  • azure-cli
  • dvc-with-remotes
  • python37Packages.azure-mgmt-loganalytics
  • python37Packages.azure-mgmt-monitor
  • python37Packages.azure-storage-blob
  • python37Packages.azure-storage-file-share
  • python37Packages.snowflake-connector-python
  • python37Packages.snowflake-sqlalchemy
  • python38Packages.azure-mgmt-loganalytics
  • python38Packages.azure-mgmt-monitor
  • python38Packages.azure-storage-blob
  • python38Packages.azure-storage-file-share
  • python38Packages.snowflake-connector-python
  • python38Packages.snowflake-sqlalchemy

@SuperSandro2000
Copy link
Member

@jonringer Should I fix the darwin issues in a separate PR?

@jonringer
Copy link
Contributor Author

yes please :)

@jonringer
Copy link
Contributor Author

jonringer commented Jan 15, 2021 •
edited

looks like darwin just need darwin.apple_sdk.frameworks.CoreFoundation?

@jonringer
Copy link
Contributor Author

actually, it might need other fixes, if you could please do the fixes in another PR, that would be great :)

@SuperSandro2000
Copy link
Member

actually, it might need other fixes, if you could please do the fixes in another PR, that would be great :)

It does and it wasn't as easy as I first thought.

@SuperSandro2000 SuperSandro2000 merged commit 974201c into NixOS:master Jan 16, 2021
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 16, 2021
Merged
10 tasks
@SuperSandro2000
Copy link
Member

@jonringer You owe me something. It took me way to long to fix it.

@jonringer
Copy link
Contributor Author

looks like it,wasn't expecting a patch to be needed.

I already owe for all the reviews you've been doing :)

@jonringer jonringer deleted the bump-azure-again branch January 16, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

@kamadorueda kamadorueda Awaiting requested review from kamadorueda

@mwilsoncoding mwilsoncoding Awaiting requested review from mwilsoncoding

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @SuperSandro2000