luaPackages: update most generated packages #109487
Closed
+158
−152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the generated file was manually edited in 4a7f99d this an attempt to try to match that
except for luv and readline, because the new versions don't build
ofborg
bot
added
6.topic: lua
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 4 packages marked as broken and skipped:
4 packages failed to build and are new build failures:
114 packages built:
|
|
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 10 packages marked as broken and skipped:
5 packages failed to build and are new build failures:
106 packages built:
|
teto
reviewed
Jan 16, 2021
| homepage = "https://github.com/sile-typesetter/cassowary.lua"; | ||
| description = "The cassowary constraint solver"; | ||
| maintainers = with maintainers; [ marsam alerque ]; | ||
| homepage = "https://github.com/simoncozens/cassowary.lua"; |
There was a problem hiding this comment.
this redirects to https://github.com/sile-typesetter/cassowary.lua
This was changed in e1f6f37 and wrongly merged because one should edit those in maintainers/scripts/luarocks-packages.csv instead. Would you mind porting the changes to the csv file instead ?
There was a problem hiding this comment.
Sure can do. Sorry I missed this ping earlier.
There was a problem hiding this comment.
I've added you as a maintainer already, the homepage is generated via the rockspec: we can override it but would be best to fix the upstream rockspec.
There was a problem hiding this comment.
Got it. I was just going to ask where the URL was! The rockspec has been fixed, there just hasn't been a release since because there haven't been code changes. We'll do that eventually, thanks for the pointers.
|
I hope I haven't said anything that made you close this :'( anyway I submitted an update #110467 is there any specific package you would want me to update ? otherwise I hope you can rebase/reopen this later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)