Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btnx: init at 2019-07-11 #109554

Closed
wants to merge 3 commits into from
Closed

Conversation

WolfangAukang
Copy link
Contributor

Motivation for this change

Daemon necessary for detecting mouse buttons

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

meta = with lib; {
homepage = "https://github.com/cdobrich/btnx";
description = "Daemon that sniffs events from the mouse event handler";
license = licenses.gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl2Only or gpl2Plus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gpl2Only. Performed the change on the next commit.

@@ -176,6 +176,8 @@ in

buildMaven = callPackage ../build-support/build-maven.nix {};

btnx = callPackage ../tools/inputmethods/btnx {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
btnx = callPackage ../tools/inputmethods/btnx {};
btnx = callPackage ../tools/inputmethods/btnx { };

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Performed the change on the next commit.

@@ -0,0 +1,39 @@
{ lib, stdenv, fetchFromGitHub, pkgconfig, libdaemon, gtk2 }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ lib, stdenv, fetchFromGitHub, pkgconfig, libdaemon, gtk2 }:
{ lib, stdenv, fetchFromGitHub, pkg-config, libdaemon, gtk2 }:

rev = "ef3f5b9aca798213427831a94ed64ed652438470";
sha256 = "1a6sl6d403bd049ds1i0hbkc0q6lh34a0hk2i3ms1jcyazca284r";
};
nativeBuildInputs = [ pkgconfig ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ pkgconfig ];
nativeBuildInputs = [ pkg-config ];

sha256 = "1mb8dgghidsdr0nrbr3l0nm4x7lcpxbf07j35bn3kbjgvzlmbsb1";
};

nativeBuildInputs = [ pkgconfig ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ pkgconfig ];
nativeBuildInputs = [ pkg-config ];

@@ -167,6 +167,10 @@ in
deps = [ innoextract file-rename ]; }
../build-support/setup-hooks/gog-unpack.sh;

btnx-config = callPackage ../applications/misc/btnx-config {
inherit (gnome2) libglade;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is either just libglade or libglademm.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case it is libglade. But for now I have set the PR in WIP because there has been an issue with the integration (application is looking for /etc/btnx content in a hardcoded way)

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@WolfangAukang WolfangAukang deleted the btnx-init branch August 14, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants