elmPackages.*: add meta #109553
elmPackages.*: add meta #109553
Conversation
turboMaCk
force-pushed
the
elmPackages-add-metadata
branch
from
287f23c
to
7a4fce1
Compare
| description = "elm-format formats Elm source code according to a standard set of rules based on the official Elm Style Guide"; | ||
| homepage = "https://github.com/avh4/elm-format"; | ||
| license = licenses.bsd3; | ||
| maintainers = [ maintainers.avh4 maintainers.turbomack ]; |
There was a problem hiding this comment.
@avh4 just so you know - I'm adding you as a maintainer to elm-format. I believe in past you were declared directly in elm-format.nix file but I think it was overwritten by cabal2nix when the file was regenerated during some update. Defining this here means we can regenerate the file without loosing the information. Feel free to suggest change if you don't want to be declared as a maintainer anymore.
There was a problem hiding this comment.
Update: turned out your profile is not in maintainer list so I removed you.
| @@ -23,6 +23,11 @@ let | |||
| wrapProgram $out/bin/elm \ | |||
| --prefix PATH ':' ${lib.makeBinPath [ nodejs ]} | |||
| ''; | |||
|
|
|||
| description = "A delightful language for reliable webapps."; | |||
There was a problem hiding this comment.
| description = "A delightful language for reliable webapps."; | |
| description = "Delightful language for reliable webapps"; |
There was a problem hiding this comment.
This is taken from https://elm-lang.org/ - I'm not sure if it makes sense to change this.
There was a problem hiding this comment.
I've removed trailing . but kept A as it is the official tagline.
| @@ -48,6 +63,11 @@ let | |||
| jailbreak = true; | |||
| # Tests are failing because of missing instances for Eq and Show type classes | |||
| doCheck = false; | |||
|
|
|||
| description = "Instrument Elm code as a preprocessing step. Meant to be using in conjunction with elm-coverage."; | |||
There was a problem hiding this comment.
description should not contain dots at the end which probably means two sentences are to long.
turboMaCk
force-pushed
the
elmPackages-add-metadata
branch
from
59f39fb
to
58ef8c8
Compare
|
@SuperSandro2000 I went through meta again and shorten the description. I think it would be still fair to wait for @domenkozar and @avh4 before we merge this since I'm declaring them as maintainers without consulting them first. Thanks for the review! |
turboMaCk
force-pushed
the
elmPackages-add-metadata
branch
from
58ef8c8
to
bd0a974
Compare
|
It turned out Aaron is not in maintainers list - removing. |
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
turboMaCk
force-pushed
the
elmPackages-add-metadata
branch
from
fa1fb7a
to
ccdf2b2
Compare
|
👍 I'm fine either way. (For the record, I still plan to submit a nixpkg PR each time there's a new elm-format version, as I've been doing for a while now.) |
Motivation for this change
elmPackageswere missing meta attributes. This PR adds all missing meta information for rest of the tooling to consume. This will be handy especially as nixos-search will soon be able to filter packages by license, maintainer etc NixOS/nixos-search#261.In the future we should also add platform information.
Things done
Added meta.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)cc @domenkozar (I've added you as a maintainer of elm compiler)