Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmap: 7.80 -> 7.91 #109555

Closed
wants to merge 1 commit into from
Closed

nmap: 7.80 -> 7.91 #109555

wants to merge 1 commit into from

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

There is an issue with the changed license. #105129 (comment)

I think a good approach, I would approve and merge, would be to split 7.80 of with the free license and create new, unfree package that has version 7.91. Naming them nmap and nmap-unfree would probably required to remain backwards compatibility.

@LeSuisse
Copy link
Contributor Author

Oups, yep indeed I missed/forgotten that :/ .

I'm closing this PR until a consensus is reached in #105119

@LeSuisse LeSuisse closed this Jan 16, 2021
@LeSuisse LeSuisse deleted the nmap-7.91 branch January 16, 2021 18:09
@ofborg ofborg bot requested review from thoughtpolice and fpletz January 16, 2021 18:09
@SuperSandro2000
Copy link
Member

Oups, yep indeed I missed/forgotten that :/ .

I'm closing this PR until a consensus is reached in #105119

That is basically the outcome in there. The license is unfree and if we want the update just split it.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LeSuisse @SuperSandro2000