Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.voluptuous-serialize: enable tests #109483

Merged
merged 1 commit into from Jan 17, 2021
Merged

python3Packages.voluptuous-serialize: enable tests #109483

merged 1 commit into from Jan 17, 2021

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Jan 15, 2021

Motivation for this change

Switch to GitHub as source and enable tests.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member Author

fabaff commented Jan 15, 2021

Result of nixpkgs-review pr 109483 run on x86_64-linux 1

4 packages built:
  • home-assistant
  • python37Packages.voluptuous-serialize
  • python38Packages.voluptuous-serialize
  • python39Packages.voluptuous-serialize

@ofborg ofborg bot requested a review from etu January 15, 2021 23:31
etu
etu approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@etu etu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the removal of disabled for python2 versions, I think this is fine.

pkgs/development/python-modules/voluptuous-serialize/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from etu January 17, 2021 09:06
@mweinelt mweinelt merged commit b6d88a4 into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabaff @mweinelt @etu