Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.check-manifest,pythonPackages.swaglyrics: Fix dependencies; botan: fix compilation on darwin #109539

Merged
merged 8 commits into from Jan 16, 2021
Merged

pythonPackages.check-manifest,pythonPackages.swaglyrics: Fix dependencies; botan: fix compilation on darwin #109539

merged 8 commits into from Jan 16, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Jan 16, 2021
@SuperSandro2000 SuperSandro2000 changed the title pythonPackages.check-manifest,pythonPackages.swaglyrics: Fix dependencies; botan: fix compilation on darwin; kea: darwin patch pythonPackages.check-manifest,pythonPackages.swaglyrics: Fix dependencies; botan: fix compilation on darwin Jan 16, 2021
sternenseemann
sternenseemann reviewed Jan 16, 2021
View reviewed changes
pkgs/development/python-modules/ufoprocessor/default.nix Outdated
@@ -26,6 +26,10 @@ buildPythonPackage rec {
mutatormath
];

# no tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests can be run using python Tests/tests.py according to source.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can people just use pytest?

Also this is you package. Maybe you should fix that in a PR not me?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure can, wasn't really broken though, was it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It printed to the log that zero tests where run and I am just cleaning that up. Nothing else. If you don't feel like getting the tests working I just update the comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just give me a minute I'll have the PR done in a few minutes

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#109550

@siraben
Copy link
Member

siraben commented Jan 16, 2021 

$ NIXPKGS_ALLOW_UNSUPPORTED_SYSTEM=1 nix-build -A swaglyrics
...
adding 'SwSpotify/__main__.py'
adding 'SwSpotify/spotify.py'
adding 'SwSpotify/web_server.py'
adding 'SwSpotify-1.2.1.dist-info/LICENSE'
adding 'SwSpotify-1.2.1.dist-info/METADATA'
adding 'SwSpotify-1.2.1.dist-info/WHEEL'
adding 'SwSpotify-1.2.1.dist-info/top_level.txt'
adding 'SwSpotify-1.2.1.dist-info/RECORD'
removing build/bdist.macosx-10.6-x86_64/wheel
Finished executing setuptoolsBuildPhase
installing
Executing pipInstallPhase
/private/tmp/nix-build-python3.8-SwSpotify-1.2.1.drv-0/source/dist /private/tmp/nix-build-python3.8-SwSpotify-1.2.1.drv-0/source
Processing ./SwSpotify-1.2.1-py3-none-any.whl
ERROR: Could not find a version that satisfies the requirement pyobjc; platform_system == "Darwin" (from swspotify)
ERROR: No matching distribution found for pyobjc; platform_system == "Darwin"
builder for '/nix/store/xm1li0fk77mbs20p1ka1h9145fixkxbk-python3.8-SwSpotify-1.2.1.drv' failed with exit code 1
cannot build derivation '/nix/store/jfvq63bkzchb43gc1bkga201c85xh6nz-swaglyrics-1.2.2.drv': 1 dependencies couldn't be built
error: build of '/nix/store/jfvq63bkzchb43gc1bkga201c85xh6nz-swaglyrics-1.2.2.drv' failed

@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 16, 2021
Closed
@SuperSandro2000
Copy link
Member Author

@siraben being tracked in #105156

@ofborg ofborg bot requested a review from sternenseemann January 16, 2021 16:59
jonringer
jonringer approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 109539 run on x86_64-linux 1

22 packages built:
  • devpi-client
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.build
  • python37Packages.check-manifest
  • python37Packages.nototools
  • python37Packages.sphinxcontrib-bibtex
  • python37Packages.ufoprocessor
  • python38Packages.afdko
  • python38Packages.build
  • python38Packages.check-manifest
  • python38Packages.nototools
  • python38Packages.sphinxcontrib-bibtex
  • python38Packages.ufoprocessor
  • python39Packages.afdko
  • python39Packages.build
  • python39Packages.nototools
  • python39Packages.sphinxcontrib-bibtex
  • python39Packages.ufoprocessor
  • swaglyrics
  • twitter-color-emoji
  • winpdb

@jonringer jonringer merged commit b153e63 into NixOS:master Jan 16, 2021
@SuperSandro2000 SuperSandro2000 deleted the fix-collection3 branch January 16, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@evanjs evanjs Awaiting requested review from evanjs

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

@bjornfor bjornfor Awaiting requested review from bjornfor

@nlewo nlewo Awaiting requested review from nlewo

@siraben siraben Awaiting requested review from siraben

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SuperSandro2000 @siraben @sternenseemann @jonringer