Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.uamqp: Fix build on darwin #109538

Merged
merged 1 commit into from Jan 16, 2021
Merged

pythonPackages.uamqp: Fix build on darwin #109538

merged 1 commit into from Jan 16, 2021

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

#109473

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Jan 16, 2021
@ofborg ofborg bot requested a review from mwilsoncoding January 16, 2021 15:11
@SuperSandro2000
Copy link
Member Author

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109538 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • python39Packages.azure-servicebus
5 packages built:
  • python37Packages.azure-servicebus
  • python37Packages.uamqp
  • python38Packages.azure-servicebus
  • python38Packages.uamqp
  • python39Packages.uamqp

@SuperSandro2000
Copy link
Member Author

Result of nixpkgs-review pr 109538 run on x86_64-linux 1

5 packages built:
  • python37Packages.azure-servicebus
  • python37Packages.uamqp
  • python38Packages.azure-servicebus
  • python38Packages.uamqp
  • python39Packages.uamqp

@Mic92 Mic92 merged commit 7f5f4ac into NixOS:master Jan 16, 2021
@jonringer
Copy link
Contributor

wow, and a patch, thanks @SuperSandro2000 wasn't expecting it to be this much work. But also shame on microsoft on not have CI around darwin.

@SuperSandro2000 SuperSandro2000 deleted the uamqp-darwin branch January 17, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@mwilsoncoding mwilsoncoding Awaiting requested review from mwilsoncoding

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SuperSandro2000 @jonringer @Mic92