Skip to content

[20.09] nixos/prometheus: remote_{read,write} #109536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2021
Merged

[20.09] nixos/prometheus: remote_{read,write} #109536

merged 1 commit into from
Jan 16, 2021
+140 −0

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Jan 16, 2021

Backport of #99180, adding remote_write and remote_read support to prometheus.

cc @WilliButz @0x4A6F

Motivation for this change

Use remote_write from NixOS 20.09

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@0x4A6F @yorickvP @flokli
nixos/prometheus: remote_{read,write}

Verified

This commit was signed with the committer’s verified signature. The key has expired.
starcraft66 Tristan
GPG key ID: 86886FC44C72EAA1
Expired
Verified
Learn about vigilant mode
5fa844b 
- add [remote_write](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#remote_write) and [remote_read](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#remote_read) support

Co-authored-by: Yorick van Pelt <yorickvanpelt@gmail.com>
(cherry picked from commit c53a0c1)
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jan 16, 2021
@flokli flokli marked this pull request as draft January 16, 2021 15:10
@flokli flokli marked this pull request as ready for review January 16, 2021 16:33
@flokli flokli merged commit 2986a77 into NixOS:release-20.09 Jan 16, 2021
@flokli flokli deleted the prometheus-remote-read-write branch January 16, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @0x4A6F