Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-rabbitmq-exporter: 0.25.2 -> 1.0.0-RC7.1 #109495

Merged
merged 1 commit into from Jan 17, 2021
Merged

prometheus-rabbitmq-exporter: 0.25.2 -> 1.0.0-RC7.1 #109495

merged 1 commit into from Jan 17, 2021

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jan 16, 2021

Otherwise, the root certificate from cloudAMQP is unsupported.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h cole-h requested a review from grahamc January 16, 2021 04:35
@cole-h cole-h mentioned this pull request Jan 16, 2021
Merged
SuperSandro2000
SuperSandro2000 requested changes Jan 16, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use buildGoModule here?

pkgs/servers/monitoring/prometheus/rabbitmq-exporter.nix Outdated Show resolved Hide resolved
pkgs/servers/monitoring/prometheus/rabbitmq-exporter.nix Outdated Show resolved Hide resolved
@cole-h
prometheus-rabbitmq-exporter: 0.25.2 -> 1.0.0-RC7.1
8216d34 
Otherwise, the root certificate from cloudAMQP is unsupported.
@SuperSandro2000
Copy link
Member

Can we use buildGoModule here?

I still have that question. Maybe a thing todo for another PR.

@SuperSandro2000 SuperSandro2000 merged commit 19e8aa6 into NixOS:master Jan 17, 2021
@cole-h
Copy link
Member Author

cole-h commented Jan 17, 2021

I don't know the difference between the two, so I'd leave it for another PR. Feel free to handle that.

@cole-h cole-h deleted the rabbitmq-exporter branch January 21, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@grahamc grahamc Awaiting requested review from grahamc

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cole-h @SuperSandro2000