Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faceted search trap click #262

Merged
merged 4 commits into from Jan 17, 2021
Merged

Conversation

turboMaCk
Copy link
Member

This is the quickfix for:

  • Click actions propagation
  • tiny improvement to visibility of clickable area.

Small improvement to display of Options details

image

Make additional thinks in detail clickable and selectable

search-selectable

Change Cursor and underline text on hover

search-cursor

Especially the hover actions will need some additional improvements but I think this might be good enough to unblock the feature.

@turboMaCk turboMaCk added the enhancement New feature or request label Jan 16, 2021
@turboMaCk turboMaCk self-assigned this Jan 16, 2021
@turboMaCk turboMaCk mentioned this pull request Jan 16, 2021
@github-actions
Copy link
Contributor

@turboMaCk turboMaCk changed the title Turbo mack/faceted search trap click faceted search trap click Jan 16, 2021
@turboMaCk turboMaCk linked an issue Jan 16, 2021 that may be closed by this pull request
@github-actions
Copy link
Contributor

@garbas garbas merged commit 3dcbd4d into faceted-search Jan 17, 2021
@garbas garbas deleted the turboMack/faceted-search-trap-click branch January 17, 2021 01:42
@turboMaCk
Copy link
Member Author

Just a tiny update to the hover action #263 <- sort of rollbacks few of changes I made since now only title is clickable - I think we should not confuse users by underlining headline unless something clickable is hovered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

faceted search for packages
2 participants