Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests with golden files are dependent on particular yosys #71

Open
hzeller opened this issue Jan 16, 2021 · 0 comments
Open

Some tests with golden files are dependent on particular yosys #71

hzeller opened this issue Jan 16, 2021 · 0 comments

Comments

@hzeller
Copy link
Collaborator

hzeller commented Jan 16, 2021

Running tests that compare against golden files are sensitive to the particular yosys the golden files have been produces with, as they often contain generated names that are dependent on the circumstances.

For instance, running

make test_design_introspection

on my machine results gets a different result for the cells compared to the golden file

< {$abc$1984$lut$not$aiger1983$1} {$auto$alumacc.cc:485:replace_alu$1385.slice[0].carry4} {$auto$alumacc.cc:485:replace_alu$1385.slice[1].carry4} {$auto$alumacc.cc:485:replace_alu$1385.slice[2].carry4} {$auto$alumacc.cc:485:replace_alu$1385.slice[3].carry4} {$auto$alumacc.cc:485:replace_alu$1385.slice[4].carry4} {$auto$alumacc.cc:485:replace_alu$1385.slice[5].carry4} {$auto$alumacc.cc:485:replace_alu$1385.slice[6].carry4} {$auto$simplemap.cc:420:simplemap_dff$1471} {$auto$simplemap.cc:420:simplemap_dff$1472} {$auto$simplemap.cc:420:simplemap_dff$1473} {$auto$simplemap.cc:420:simplemap_dff$1474} {$auto$simplemap.cc:420:simplemap_dff$1475} {$auto$simplemap.cc:420:simplemap_dff$1476} {$auto$simplemap.cc:420:simplemap_dff$1477} {$auto$simplemap.cc:420:simplemap_dff$1478} {$auto$simplemap.cc:420:simplemap_dff$1479} {$auto$simplemap.cc:420:simplemap_dff$1480} {$auto$simplemap.cc:420:simplemap_dff$1481} {$auto$simplemap.cc:420:simplemap_dff$1482} {$auto$simplemap.cc:420:simplemap_dff$1483} {$auto$simplemap.cc:420:simplemap_dff$1484} {$auto$simplemap.cc:420:simplemap_dff$1485} {$auto$simplemap.cc:420:simplemap_dff$1486} {$auto$simplemap.cc:420:simplemap_dff$1487} {$auto$simplemap.cc:420:simplemap_dff$1488} {$auto$simplemap.cc:420:simplemap_dff$1489} {$auto$simplemap.cc:420:simplemap_dff$1490} {$auto$simplemap.cc:420:simplemap_dff$1491} {$auto$simplemap.cc:420:simplemap_dff$1492} {$auto$simplemap.cc:420:simplemap_dff$1493} {$auto$simplemap.cc:420:simplemap_dff$1494} {$auto$simplemap.cc:420:simplemap_dff$1495} {$auto$simplemap.cc:420:simplemap_dff$1496} {$iopadmap$top.clk} OBUFTDS_2 OBUF_6 OBUF_7 OBUF_OUT bottom_inst.OBUF_10 bottom_inst.OBUF_11 bottom_inst.OBUF_9 bottom_intermediate_inst.OBUF_8
---
> {$abc$2067$lut$not$aiger2066$1} {$auto$alumacc.cc:485:replace_alu$1466.slice[0].carry4} {$auto$alumacc.cc:485:replace_alu$1466.slice[1].carry4} {$auto$alumacc.cc:485:replace_alu$1466.slice[2].carry4} {$auto$alumacc.cc:485:replace_alu$1466.slice[3].carry4} {$auto$alumacc.cc:485:replace_alu$1466.slice[4].carry4} {$auto$alumacc.cc:485:replace_alu$1466.slice[5].carry4} {$auto$alumacc.cc:485:replace_alu$1466.slice[6].carry4} {$auto$simplemap.cc:420:simplemap_dff$1552} {$auto$simplemap.cc:420:simplemap_dff$1553} {$auto$simplemap.cc:420:simplemap_dff$1554} {$auto$simplemap.cc:420:simplemap_dff$1555} {$auto$simplemap.cc:420:simplemap_dff$1556} {$auto$simplemap.cc:420:simplemap_dff$1557} {$auto$simplemap.cc:420:simplemap_dff$1558} {$auto$simplemap.cc:420:simplemap_dff$1559} {$auto$simplemap.cc:420:simplemap_dff$1560} {$auto$simplemap.cc:420:simplemap_dff$1561} {$auto$simplemap.cc:420:simplemap_dff$1562} {$auto$simplemap.cc:420:simplemap_dff$1563} {$auto$simplemap.cc:420:simplemap_dff$1564} {$auto$simplemap.cc:420:simplemap_dff$1565} {$auto$simplemap.cc:420:simplemap_dff$1566} {$auto$simplemap.cc:420:simplemap_dff$1567} {$auto$simplemap.cc:420:simplemap_dff$1568} {$auto$simplemap.cc:420:simplemap_dff$1569} {$auto$simplemap.cc:420:simplemap_dff$1570} {$auto$simplemap.cc:420:simplemap_dff$1571} {$auto$simplemap.cc:420:simplemap_dff$1572} {$auto$simplemap.cc:420:simplemap_dff$1573} {$auto$simplemap.cc:420:simplemap_dff$1574} {$auto$simplemap.cc:420:simplemap_dff$1575} {$auto$simplemap.cc:420:simplemap_dff$1576} {$auto$simplemap.cc:420:simplemap_dff$1577} {$iopadmap$top.clk} OBUFTDS_2 OBUF_6 OBUF_7 OBUF_OUT bottom_inst.OBUF_10 bottom_inst.OBUF_11 bottom_inst.OBUF_9 bottom_intermediate_inst.OBUF_8

So to compare, these should probably scrub the individual names, so that a comparison can just focus on the structure of the output.

mglb pushed a commit to antmicro/yosys-f4pga-plugins that referenced this issue Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant