Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

burpsuite: 2020.1 -> 2020.12.1 #109549

Merged
merged 1 commit into from Jan 17, 2021
Merged

burpsuite: 2020.1 -> 2020.12.1 #109549

merged 1 commit into from Jan 17, 2021

Conversation

LeSuisse
Copy link
Contributor

Motivation for this change

Also moved to Java 11 to avoid warnings when launching Burp Suite.
Burp Suite only officially supports Java versions 9 to 14.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LeSuisse
burpsuite: 2020.1 -> 2020.12.1
2c29f2a 
Moved to Java 11 to avoid warnings when launching Burp Suite.
Burp Suite only officially supports Java versions 9 to 14 [0].

[0] https://portswigger.net/burp/documentation/desktop/getting-started/launching/command-line#checking-your-java-version
@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109549 run on x86_64-linux 1

1 package built:
  • burpsuite

@SuperSandro2000 SuperSandro2000 merged commit ff9a7c6 into NixOS:master Jan 17, 2021
@LeSuisse LeSuisse deleted the bursuite-2020.12.1 branch January 17, 2021 12:43
@buckley310 buckley310 mentioned this pull request Jan 17, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSuisse @SuperSandro2000 @Janik-Haag