Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ns-3: Fix hash for 3.33 #109547

Merged
merged 1 commit into from Jan 17, 2021
Merged

ns-3: Fix hash for 3.33 #109547

merged 1 commit into from Jan 17, 2021

Conversation

rgrunbla
Copy link
Contributor

@rgrunbla rgrunbla commented Jan 16, 2021 •
edited

Motivation for this change

Fix the hash for the 3.33 version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rgrunbla rgrunbla requested a review from teto January 16, 2021 16:24
@rgrunbla rgrunbla marked this pull request as draft January 16, 2021 17:09
@rgrunbla rgrunbla marked this pull request as ready for review January 17, 2021 07:54
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109547 run on x86_64-darwin 1

1 package built:
  • ns-3

There are several binaries in the output which are not linked correct:

ls results/ns-3/bin/
ns3.33-bench-packets-debug               ns3.33-bench-simulator-debug             ns3.33-print-introspected-doxygen-debug

results/ns-3/bin/ns3.33-print-introspected-doxygen-debug
dyld: Library not loaded: /private/tmp/nix-build-ns-3-33.drv-0/source/build/lib/libns3.33-point-to-point-layout-debug.dylib
  Referenced from: /Users/user/.cache/nixpkgs-review/pr-109547/results/ns-3/bin/ns3.33-print-introspected-doxygen-debug
  Reason: image not found
Abort trap: 6

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109547 run on x86_64-linux 1

1 package built:
  • ns-3

@rgrunbla
Copy link
Contributor Author

Result of nixpkgs-review pr 109547 run on x86_64-darwin 1

Afraid I cannot try to find out if this is normal or not as I do not own any macOS machine.

@teto
Copy link
Member

teto commented Jan 17, 2021 •
edited

meta.platforms ignoresdarwin so the failure reported by sandro2000 is of no importance. I think darwin requires to pass some additionnal buildInputs to work but it's best left to someone actually running ns-3 than darwin. Merging. And thnaks for quickfix.

@teto teto merged commit 84d0ecf into NixOS:master Jan 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgrunbla @SuperSandro2000 @teto