Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hedgedoc: 1.7.1 -> 1.7.2, fixes CVE-2021-21259 #109484

Merged
merged 1 commit into from Jan 16, 2021
Merged

hedgedoc: 1.7.1 -> 1.7.2, fixes CVE-2021-21259 #109484

merged 1 commit into from Jan 16, 2021

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/hedgedoc/hedgedoc/releases/tag/1.7.2

CVE-2021-21259:
GHSA-44w9-vm8p-3cxw

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Deployed to an existing HedgeDoc instance

@WilliButz WilliButz added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. 9.needs: port to stable A PR needs a backport to the stable release. and removed 8.has: port to stable A PR already has a backport to the stable release. labels Jan 15, 2021
@ofborg ofborg bot requested review from Ma27 and globin January 16, 2021 00:04
@bbigras
Copy link
Contributor

bbigras commented Jan 16, 2021

Result of nixpkgs-review pr 109484 run on x86_64-linux 1

1 package built:
  • hedgedoc

@bbigras
Copy link
Contributor

bbigras commented Jan 16, 2021

Thanks for the quick update.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109484 run on x86_64-linux 1

1 package built:
  • hedgedoc

@SuperSandro2000 SuperSandro2000 merged commit abb4941 into NixOS:master Jan 16, 2021
@Ma27
Copy link
Member

Ma27 commented Jan 16, 2021

@SuperSandro2000 do you also take care of the backport?

@Ma27
Copy link
Member

Ma27 commented Jan 17, 2021

Ported to stable as 9e3d5d9.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 17, 2021
@SuperSandro2000
Copy link
Member

@SuperSandro2000 do you also take care of the backport?

I usually do not backport things or review them.

@Ma27
Copy link
Member

Ma27 commented Jan 17, 2021

So... you don't review things you merge in the end?

@WilliButz WilliButz deleted the update/hedgedoc/1.7.2 branch January 25, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbigras bbigras bbigras approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
1.severity: security 8.has: documentation 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WilliButz @bbigras @SuperSandro2000 @Ma27