Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: c2462bb3914a
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 21d78fa465fd
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Jan 16, 2021

  1. nixos/zfs: make zpool-trim timer persistent 

    If the machine is powered off when the zpool-trim timer is supposed to
trigger (usually around midnight) then the timer will be skipped
outright in favor of the next instance.

For desktop systems which are usually powered off at this time, zpool
trimming will never be run which can degrade SSD performance.

By marking the timer as `Persistent = yes` we ensure that it will run at
the first possible opportunity after the trigger date is reached.
    @ipetkov
    ipetkov committed Jan 16, 2021

    Verified

    This commit was signed with the committer’s verified signature.
    renovate-bot Mend Renovate
    GPG key ID: 81C63AE1C224182B
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e2fa74d View commit details

  2. Merge pull request #109494 from ipetkov/nixos-zpool-trim-persistent-t… 

    …imer

nixos/zfs: make zpool-trim timer persistent
    @Mic92
    Mic92 authored Jan 16, 2021
    Copy the full SHA
    21d78fa View commit details
Showing with 2 additions and 0 deletions.
  1. +2 −0 nixos/modules/tasks/filesystems/zfs.nix
2 changes: 2 additions & 0 deletions nixos/modules/tasks/filesystems/zfs.nix
View file
Original file line number Diff line number Diff line change
@@ -664,6 +664,8 @@ in
# - There are only HDDs and we would set the system in a degraded state
serviceConfig.ExecStart = ''${pkgs.runtimeShell} -c 'for pool in $(zpool list -H -o name); do zpool trim $pool; done || true' '';
};

systemd.timers.zpool-trim.timerConfig.Persistent = "yes";
})
];
}