Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.fritzconnection: 1.2.1 -> 1.4.0 #109525

Merged
merged 1 commit into from Jan 16, 2021
Merged

python3Packages.fritzconnection: 1.2.1 -> 1.4.0 #109525

merged 1 commit into from Jan 16, 2021

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda changed the title fritzconnection: 1.2.1 -> 1.4.0 python3Packages.fritzconnection: 1.2.1 -> 1.4.0 Jan 16, 2021
Valodim
Valodim approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pkgs/development/python-modules/fritzconnection/default.nix Show resolved Hide resolved
pkgs/development/python-modules/fritzconnection/default.nix Show resolved Hide resolved
mweinelt
mweinelt requested changes Jan 16, 2021
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new homepage is https://github.com/kbr/fritzconnection.

@ofborg ofborg bot requested a review from Valodim January 16, 2021 14:34
@mweinelt mweinelt merged commit afc9b7b into NixOS:master Jan 16, 2021
@dotlambda dotlambda deleted the fritzconnection-1.4.0 branch January 16, 2021 19:10
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109525 run on x86_64-linux 1

3 packages built:
  • python37Packages.fritzconnection
  • python38Packages.fritzconnection
  • python39Packages.fritzconnection

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109525 run on x86_64-darwin 1

3 packages built:
  • python37Packages.fritzconnection
  • python38Packages.fritzconnection
  • python39Packages.fritzconnection

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@Valodim Valodim Awaiting requested review from Valodim

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @SuperSandro2000 @Valodim @mweinelt