Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mpvScripts.mpvacious: init at 0.12 #109545

Merged
merged 2 commits into from Jan 17, 2021
Merged

mpvScripts.mpvacious: init at 0.12 #109545

merged 2 commits into from Jan 17, 2021

Conversation

kmicklas
Copy link
Contributor

Motivation for this change

This is a useful MPV script for language learners.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kmicklas kmicklas changed the title mpvScripts.mpvacious: init at v0.12 mpvScripts.mpvacious: init at 0.12 Jan 16, 2021
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109545 run on x86_64-darwin 1

1 package built:
  • mpvScripts.mpvacious

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109545 run on x86_64-linux 1

1 package built:
  • mpvScripts.mpvacious

@SuperSandro2000 SuperSandro2000 merged commit ec64627 into NixOS:master Jan 17, 2021
@kmicklas kmicklas deleted the mpvacious branch January 17, 2021 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kmicklas @SuperSandro2000 @teto