Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lepton-eda: init at 1.9.13-20201211 #109552

Merged
merged 2 commits into from Aug 5, 2021
Merged

lepton-eda: init at 1.9.13-20201211 #109552

merged 2 commits into from Aug 5, 2021

Conversation

tesq0
Copy link
Contributor

@tesq0 tesq0 commented Jan 16, 2021

Motivation for this change

Needed some nice software for designing electronics

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Jan 16, 2021
View reviewed changes
pkgs/applications/science/electronics/lepton-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/lepton-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/lepton-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/lepton-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/lepton-eda/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/lepton-eda/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gtkextra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gtkextra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gtkextra/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/gtkextra/default.nix Outdated Show resolved Hide resolved
@stale
Copy link

stale bot commented Jul 16, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 16, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 5, 2021
SuperSandro2000
SuperSandro2000 reviewed Aug 5, 2021
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

@SuperSandro2000 SuperSandro2000 merged commit cfdee17 into NixOS:master Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tesq0 @SuperSandro2000