New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gdu: 2.3.0 -> 3.0.0 #109491
gdu: 2.3.0 -> 3.0.0 #109491
Conversation
Result of 1 package built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- package build (see gdu: 2.3.0 -> 3.0.0 #109491 (comment))
- all depending packages build
- executables tested on x86_64
w/pr-109491/results]$ ./gdu/bin/gdu -v
Version: 3.0.0
Built time:
Built user:
I'm not sure about the guidelines in regard of additional details in the output which are set by the build system. Perhaps we could set the time to the current day or add a timestamp and set User
to Nix Build System
or so.
Otherwise, looks good to me.
# analyze/dev_test.go: undefined: processMounts | ||
doCheck = !stdenv.isDarwin; | ||
# tests fail is the version is set | ||
doCheck = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TestVersion
is using development
. Looks like that the tests could pass by replacing development
with the current version.
doCheck = false; | |
postPatch = '' | |
substituteInPlace cmd/cmd_test.go --replace "development" "${version}" | |
''; |
Time would need to be fixed value (i.e. SOURCE_DATE_EPOCH or similar) otherwise it's an impurity. As neither of them are necessary or provide useful information I don't see that we need to set them.
I don't think we should bother with this as it doesn't seem like it is meant to be run by downstream packagers and the tests still don't work on some platforms anyway. If the quick releases by upstream continue we'd likely need to keep adjusting it as well. |
This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch) Result of 1 package built:
|
https://github.com/dundee/gdu/releases/tag/v3.0.0
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)