Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdu: 2.3.0 -> 3.0.0 #109491

Merged
merged 1 commit into from Jan 18, 2021
Merged

gdu: 2.3.0 -> 3.0.0 #109491

merged 1 commit into from Jan 18, 2021

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Jan 16, 2021

https://github.com/dundee/gdu/releases/tag/v3.0.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabaff
Copy link
Member

fabaff commented Jan 16, 2021

Result of nixpkgs-review pr 109491 run on x86_64-linux 1

1 package built:
  • gdu

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w/pr-109491/results]$ ./gdu/bin/gdu -v
Version:	 3.0.0
Built time:	 
Built user:	 

I'm not sure about the guidelines in regard of additional details in the output which are set by the build system. Perhaps we could set the time to the current day or add a timestamp and set User to Nix Build System or so.

Otherwise, looks good to me.

# analyze/dev_test.go: undefined: processMounts
doCheck = !stdenv.isDarwin;
# tests fail is the version is set
doCheck = false;
Copy link
Member

@fabaff fabaff Jan 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TestVersion is using development. Looks like that the tests could pass by replacing development with the current version.

Suggested change
doCheck = false;
postPatch = ''
substituteInPlace cmd/cmd_test.go --replace "development" "${version}"
'';

@zowoq
Copy link
Contributor Author

zowoq commented Jan 16, 2021

Perhaps we could set the time to the current day or add a timestamp and set User to Nix Build System or so.

Time would need to be fixed value (i.e. SOURCE_DATE_EPOCH or similar) otherwise it's an impurity.

As neither of them are necessary or provide useful information I don't see that we need to set them.

Looks like that the tests could pass by replacing development with the current version.

I don't think we should bother with this as it doesn't seem like it is meant to be run by downstream packagers and the tests still don't work on some platforms anyway. If the quick releases by upstream continue we'd likely need to keep adjusting it as well.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109491 run on x86_64-darwin 1

1 package built:
  • gdu

@ofborg ofborg bot requested a review from fabaff January 18, 2021 03:17
@zowoq zowoq merged commit cd9256a into NixOS:master Jan 18, 2021
@zowoq zowoq deleted the gdu branch January 18, 2021 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants