Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] virtualbox: 6.1.14 -> 6.1.16 #107421

Merged
merged 1 commit into from Jan 16, 2021
Merged

[20.09] virtualbox: 6.1.14 -> 6.1.16 #107421

merged 1 commit into from Jan 16, 2021

Conversation

greizgh
Copy link
Contributor

@greizgh greizgh commented Dec 22, 2020 •
edited

Motivation for this change

Backport #101493

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Magicloud @greizgh
virtualbox: 6.1.14 -> 6.1.16
1c15b87 
6.1.16 is the latest release of Virtualbox. And it is necessary to have it when using Linux 5.9 kernel.

(cherry picked from commit e416dc8)
@bryanasdev000 bryanasdev000 mentioned this pull request Dec 28, 2020
Closed
10 tasks
bryanasdev000 referenced this pull request Jan 3, 2021
@Magicloud
virtualbox: 6.1.14 -> 6.1.16
e416dc8 
6.1.16 is the latest release of Virtualbox. And it is necessary to have it when using Linux 5.9 kernel.
@bryanasdev000 bryanasdev000 mentioned this pull request Jan 3, 2021
Closed
thiagokokada
thiagokokada approved these changes Jan 3, 2021
View reviewed changes
Copy link
Contributor

@thiagokokada thiagokokada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but code-wise LGTM.

@jecaro
Copy link
Contributor

jecaro commented Jan 15, 2021

I'm really in need of this to be merged. In the meantime a workaround would be greatly appreciated.

@blitz
Copy link
Contributor

blitz commented Jan 15, 2021

@svanderburg @cdepillabout Can you take a look at this?

@cdepillabout
Copy link
Member

In general we don't do version bumps on the release branches, but it sounds like this might be necessary for people running 5.9 kernels.

Let's ping the release managers and see if they have any opinion on this (@worldofpeace and @jonringer).

jonringer
jonringer approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

According to https://www.virtualbox.org/wiki/Changelog it's a maintenance release, so there shouldn't be any regressions.

@jonringer
Copy link
Contributor

In general we don't do version bumps on the release branches,

We try to avoid breaking version bumps, but bug fixes and security updates are still welcome.

@jonringer
Copy link
Contributor

@GrahamcOfBorg test virtualbox

@jonringer jonringer merged commit 653c633 into NixOS:release-20.09 Jan 16, 2021
@jonringer
Copy link
Contributor 

https://github.com/NixOS/nixpkgs/pull/107421

16 packages marked as broken and skipped:
linuxPackages_5_9.virtualbox linuxPackages_5_9.virtualboxGuestAdditions linuxPackages_hardkernel_4_14.virtualbox linuxPackages_hardkernel_4_14.virtualboxGuestAdditions linuxPackages_hardkernel_latest.virtualbox linuxPackages_hardkernel_latest.virtualboxGuestAdditions linuxPackages_latest-libre.virtualbox linuxPackages_latest-libre.virtualboxGuestAdditions linuxPackages_latest.virtualbox linuxPackages_latest.virtualboxGuestAdditions linuxPackages_latest_hardened.virtualbox linuxPackages_latest_hardened.virtualboxGuestAdditions linuxPackages_latest_xen_dom0.virtualbox linuxPackages_latest_xen_dom0.virtualboxGuestAdditions linuxPackages_latest_xen_dom0_hardened.virtualbox linuxPackages_latest_xen_dom0_hardened.virtualboxGuestAdditions

29 packages built:
linuxPackages-libre.virtualbox linuxPackages-libre.virtualboxGuestAdditions linuxPackages.virtualbox linuxPackages.virtualboxGuestAdditions linuxPackages_4_14.virtualbox linuxPackages_4_14.virtualboxGuestAdditions linuxPackages_4_19.virtualbox linuxPackages_4_19.virtualboxGuestAdditions linuxPackages_4_4.virtualbox linuxPackages_4_4.virtualboxGuestAdditions linuxPackages_4_9.virtualbox linuxPackages_4_9.virtualboxGuestAdditions linuxPackages_5_8.virtualbox linuxPackages_5_8.virtualboxGuestAdditions linuxPackages_hardened.virtualbox linuxPackages_hardened.virtualboxGuestAdditions linuxPackages_testing_bcachefs.virtualbox linuxPackages_testing_bcachefs.virtualboxGuestAdditions linuxPackages_xen_dom0.virtualbox linuxPackages_xen_dom0.virtualboxGuestAdditions linuxPackages_xen_dom0_hardened.virtualbox linuxPackages_xen_dom0_hardened.virtualboxGuestAdditions linuxPackages_zen.virtualbox linuxPackages_zen.virtualboxGuestAdditions virtualbox virtualboxExtpack virtualboxHardened virtualboxHeadless virtualboxWithExtpack

jonringer
jonringer approved these changes Jan 16, 2021
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 107421 run on x86_64-linux 1

16 packages marked as broken and skipped:
  • linuxPackages_5_9.virtualbox
  • linuxPackages_5_9.virtualboxGuestAdditions
  • linuxPackages_hardkernel_4_14.virtualbox
  • linuxPackages_hardkernel_4_14.virtualboxGuestAdditions
  • linuxPackages_hardkernel_latest.virtualbox
  • linuxPackages_hardkernel_latest.virtualboxGuestAdditions
  • linuxPackages_latest-libre.virtualbox
  • linuxPackages_latest-libre.virtualboxGuestAdditions
  • linuxPackages_latest.virtualbox
  • linuxPackages_latest.virtualboxGuestAdditions
  • linuxPackages_latest_hardened.virtualbox
  • linuxPackages_latest_hardened.virtualboxGuestAdditions
  • linuxPackages_latest_xen_dom0.virtualbox
  • linuxPackages_latest_xen_dom0.virtualboxGuestAdditions
  • linuxPackages_latest_xen_dom0_hardened.virtualbox
  • linuxPackages_latest_xen_dom0_hardened.virtualboxGuestAdditions
29 packages built:
  • linuxPackages-libre.virtualbox
  • linuxPackages-libre.virtualboxGuestAdditions
  • linuxPackages.virtualbox (linuxPackages_5_4.virtualbox)
  • linuxPackages.virtualboxGuestAdditions (linuxPackages_5_4.virtualboxGuestAdditions)
  • linuxPackages_4_14.virtualbox
  • linuxPackages_4_14.virtualboxGuestAdditions
  • linuxPackages_4_19.virtualbox
  • linuxPackages_4_19.virtualboxGuestAdditions
  • linuxPackages_4_4.virtualbox
  • linuxPackages_4_4.virtualboxGuestAdditions
  • linuxPackages_4_9.virtualbox
  • linuxPackages_4_9.virtualboxGuestAdditions
  • linuxPackages_5_8.virtualbox
  • linuxPackages_5_8.virtualboxGuestAdditions
  • linuxPackages_hardened.virtualbox
  • linuxPackages_hardened.virtualboxGuestAdditions
  • linuxPackages_testing_bcachefs.virtualbox
  • linuxPackages_testing_bcachefs.virtualboxGuestAdditions
  • linuxPackages_xen_dom0.virtualbox
  • linuxPackages_xen_dom0.virtualboxGuestAdditions
  • linuxPackages_xen_dom0_hardened.virtualbox
  • linuxPackages_xen_dom0_hardened.virtualboxGuestAdditions
  • linuxPackages_zen.virtualbox
  • linuxPackages_zen.virtualboxGuestAdditions
  • virtualbox
  • virtualboxExtpack
  • virtualboxHardened
  • virtualboxHeadless
  • virtualboxWithExtpack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blitz blitz blitz approved these changes

@unode unode unode approved these changes

@thiagokokada thiagokokada thiagokokada approved these changes

@robertodr robertodr robertodr approved these changes

@jonringer jonringer jonringer approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@greizgh @jecaro @blitz @cdepillabout @jonringer @unode @thiagokokada @robertodr @Magicloud