-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[20.09] virtualbox: 6.1.14 -> 6.1.16 #107421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6.1.16 is the latest release of Virtualbox. And it is necessary to have it when using Linux 5.9 kernel. (cherry picked from commit e416dc8)
6.1.16 is the latest release of Virtualbox. And it is necessary to have it when using Linux 5.9 kernel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test but code-wise LGTM.
I'm really in need of this to be merged. In the meantime a workaround would be greatly appreciated. |
@svanderburg @cdepillabout Can you take a look at this? |
In general we don't do version bumps on the release branches, but it sounds like this might be necessary for people running 5.9 kernels. Let's ping the release managers and see if they have any opinion on this (@worldofpeace and @jonringer). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
According to https://www.virtualbox.org/wiki/Changelog it's a maintenance release, so there shouldn't be any regressions.
We try to avoid breaking version bumps, but bug fixes and security updates are still welcome. |
@GrahamcOfBorg test virtualbox |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Result of nixpkgs-review pr 107421 run on x86_64-linux 1
16 packages marked as broken and skipped:
- linuxPackages_5_9.virtualbox
- linuxPackages_5_9.virtualboxGuestAdditions
- linuxPackages_hardkernel_4_14.virtualbox
- linuxPackages_hardkernel_4_14.virtualboxGuestAdditions
- linuxPackages_hardkernel_latest.virtualbox
- linuxPackages_hardkernel_latest.virtualboxGuestAdditions
- linuxPackages_latest-libre.virtualbox
- linuxPackages_latest-libre.virtualboxGuestAdditions
- linuxPackages_latest.virtualbox
- linuxPackages_latest.virtualboxGuestAdditions
- linuxPackages_latest_hardened.virtualbox
- linuxPackages_latest_hardened.virtualboxGuestAdditions
- linuxPackages_latest_xen_dom0.virtualbox
- linuxPackages_latest_xen_dom0.virtualboxGuestAdditions
- linuxPackages_latest_xen_dom0_hardened.virtualbox
- linuxPackages_latest_xen_dom0_hardened.virtualboxGuestAdditions
29 packages built:
- linuxPackages-libre.virtualbox
- linuxPackages-libre.virtualboxGuestAdditions
- linuxPackages.virtualbox (linuxPackages_5_4.virtualbox)
- linuxPackages.virtualboxGuestAdditions (linuxPackages_5_4.virtualboxGuestAdditions)
- linuxPackages_4_14.virtualbox
- linuxPackages_4_14.virtualboxGuestAdditions
- linuxPackages_4_19.virtualbox
- linuxPackages_4_19.virtualboxGuestAdditions
- linuxPackages_4_4.virtualbox
- linuxPackages_4_4.virtualboxGuestAdditions
- linuxPackages_4_9.virtualbox
- linuxPackages_4_9.virtualboxGuestAdditions
- linuxPackages_5_8.virtualbox
- linuxPackages_5_8.virtualboxGuestAdditions
- linuxPackages_hardened.virtualbox
- linuxPackages_hardened.virtualboxGuestAdditions
- linuxPackages_testing_bcachefs.virtualbox
- linuxPackages_testing_bcachefs.virtualboxGuestAdditions
- linuxPackages_xen_dom0.virtualbox
- linuxPackages_xen_dom0.virtualboxGuestAdditions
- linuxPackages_xen_dom0_hardened.virtualbox
- linuxPackages_xen_dom0_hardened.virtualboxGuestAdditions
- linuxPackages_zen.virtualbox
- linuxPackages_zen.virtualboxGuestAdditions
- virtualbox
- virtualboxExtpack
- virtualboxHardened
- virtualboxHeadless
- virtualboxWithExtpack
Motivation for this change
Backport #101493
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)