Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ufoprocessor: fix test execution #109550

Merged
merged 1 commit into from Jan 17, 2021
Merged

pythonPackages.ufoprocessor: fix test execution #109550

merged 1 commit into from Jan 17, 2021

Conversation

sternenseemann
Copy link
Member

Motivation for this change

execute non standard test suite

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann sternenseemann mentioned this pull request Jan 16, 2021
Merged
10 tasks
@jonringer
Copy link
Contributor

do you mind rebasing on the latest master, I think the tests are now disabled

@sternenseemann
Copy link
Member Author

Already have.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109550 run on x86_64-darwin 1

10 packages built:
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.nototools
  • python37Packages.ufoprocessor
  • python38Packages.afdko
  • python38Packages.nototools
  • python38Packages.ufoprocessor
  • python39Packages.afdko
  • python39Packages.nototools
  • python39Packages.ufoprocessor

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which does not build all packages (e.g. lumo, tensorflow or pytorch)
If you find some bugs or got suggestions for further things to search or run please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 109550 run on x86_64-linux 1

11 packages built:
  • noto-fonts-emoji
  • python37Packages.afdko
  • python37Packages.nototools
  • python37Packages.ufoprocessor
  • python38Packages.afdko
  • python38Packages.nototools
  • python38Packages.ufoprocessor
  • python39Packages.afdko
  • python39Packages.nototools
  • python39Packages.ufoprocessor
  • twitter-color-emoji

@SuperSandro2000 SuperSandro2000 merged commit 5ee79ca into NixOS:master Jan 17, 2021
@sternenseemann sternenseemann deleted the ufoprocessor-tests branch January 17, 2021 12:40
@sternenseemann sternenseemann restored the ufoprocessor-tests branch July 24, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sternenseemann @jonringer @SuperSandro2000