Skip to content

ocamlPackages.ocurl: enable curl.lwt #109526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2021
Merged

ocamlPackages.ocurl: enable curl.lwt #109526

merged 1 commit into from
Jan 16, 2021
+2 −2

Conversation

sternenseemann
Copy link
Member

Motivation for this change

tests of git-unix >= 3.0.0 depend on curl.lwt which is exposed only if ocurl is compiled with lwt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@bennofs
Copy link
Contributor

bennofs commented Jan 16, 2021

@GrahamcOfBorg build google-drive-ocamlfuse libbap

@bennofs bennofs merged commit 95433ce into NixOS:master Jan 16, 2021
@sternenseemann sternenseemann deleted the ocurl-lwt branch January 16, 2021 18:09
@sternenseemann sternenseemann restored the ocurl-lwt branch July 24, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bennofs bennofs

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @bennofs