Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve raster scale for nested and unknown-scale transform animations #27207

Merged
merged 1 commit into from Jan 19, 2021

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Jan 16, 2021

  • When calculating the maximum animation to screen scale, for a nested
    or unknown-scale transform animation, use the parent's maximum
    animation scale instead of kInvalidScale which would fallback to
    page_scale * device_scale which ignored ancestor scales.

  • When adjusting raster scale for transform animation, use
    max(raster_contents_scale_, maximum_animation_scale).
    In normal cases, if the former is bigger than the latter, it means
    that raster_contents_scale_ calculated when the animation starts is
    more accurate than the maximum_animation_scale calculated by the
    cc/animation subsystem.

  • In case that a bigger scale than 1.5x of the previous calculated
    animation scale, force an raster scale. The case should be rare.

Bug: 1165408
Change-Id: Ieccdb9e16fb6f151e74a881855ce3655e857c372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633800
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844899}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The review process for this patch is being conducted in the Chromium project.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-2633800 branch 4 times, most recently from e992ba0 to c7f5cec Compare January 19, 2021 17:34
- When calculating the maximum animation to screen scale, for a nested
  or unknown-scale transform animation, use the parent's maximum
  animation scale instead of kInvalidScale which would fallback to
  page_scale * device_scale which ignored ancestor scales.

- When adjusting raster scale for transform animation, use
  max(raster_contents_scale_, maximum_animation_scale).
  In normal cases, if the former is bigger than the latter, it means
  that raster_contents_scale_ calculated when the animation starts is
  more accurate than the maximum_animation_scale calculated by the
  cc/animation subsystem.

- In case that a bigger scale than 1.5x of the previous calculated
  animation scale, force an raster scale. The case should be rare.

Bug: 1165408
Change-Id: Ieccdb9e16fb6f151e74a881855ce3655e857c372
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633800
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844899}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants