Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ns-3: 3.32 -> 3.33 #109540

Merged
merged 1 commit into from Jan 16, 2021
Merged

ns-3: 3.32 -> 3.33 #109540

merged 1 commit into from Jan 16, 2021

Conversation

rgrunbla
Copy link
Contributor

Motivation for this change

Updating the ns-3 package and removing temporary fix because wafHook was fixed. Adding myself to maintainers as I plan to regularly use this program.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from teto January 16, 2021 15:31
@teto teto merged commit f1e043b into NixOS:master Jan 16, 2021
@teto
Copy link
Member

teto commented Jan 16, 2021

happy to see you as a maintainer.

@teto
Copy link
Member

teto commented Jan 16, 2021

wait I've just realized you haven't updated the hash :/

@rgrunbla
Copy link
Contributor Author

Whelp, let me fix this real quick :|

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109540 run on x86_64-linux 1

1 package built:
  • ns-3

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 109540 run on x86_64-darwin 1

1 package built:
  • ns-3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto Awaiting requested review from teto

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rgrunbla @teto @SuperSandro2000