[layout] Don't allow non-formatting-context to be relayout-roots. #27710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 19, 2021
As lots of state can be passed from a non-fc to its sibling, treating these as formatting context roots is incorrect for lots of edge cases. This patch dis-allows non-fcs to be relayout-roots. Change-Id: Ieef1a2ad1d653bd954a8a9989aecc8ac83107f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2707136 Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#856317}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2707136
branch
from
92cf531
to
241f601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As lots of state can be passed from a non-fc to its sibling, treating
these as formatting context roots is incorrect for lots of edge cases.
This patch dis-allows non-fcs to be relayout-roots.
Change-Id: Ieef1a2ad1d653bd954a8a9989aecc8ac83107f69
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2707136
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#856317}