Codechange: rename sound ids to make more sense. #8701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
The enum items in SoundFx roughly reflected, what the sound effects sounded like, when someone heard them without context.
Many sound effects were mislabeled, like "plane crashing" for the "toyland plane takeoff"-effect, or attributing "truck" sounds to "busses". Many sounds had arbitrary names like "another jet overhead".
Description
This PR renames almost all items in SoundFx, and adds comments, how/where they are used in the source.
Similar used sounds get similar names:
Limitations
Poor NML people who copied the non-sensical names 馃槩
The separation into two commits is just for reviewing. This PR is intended to be squashed.
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.