Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change: Check that user code doesn't try to use reserved registers #189

Merged
merged 1 commit into from Feb 20, 2021
Merged

Change: Check that user code doesn't try to use reserved registers #189

merged 1 commit into from Feb 20, 2021

Conversation

FLHerne
Copy link
Contributor

@FLHerne FLHerne commented Feb 20, 2021

We use this range for internal calculations, so user code could get its
values overwritten by ours or vice versa.

Of course this won't catch dynamically-calculated addresses.

@FLHerne FLHerne mentioned this pull request Feb 20, 2021
Merged
@frosch123
Copy link
Member

I looked up the origin of "0xFF: Used for some house variables".
This refers to "house_same_class" in action2var_variables.
So this variable is also reserved by NML.

@FLHerne
Change: Check that user code doesn't try to use reserved registers
dbf0ce9 
We use this range for internal calculations, so user code could get its
values overwritten by ours or vice versa.

Of course this won't catch dynamically-calculated addresses.
@FLHerne FLHerne merged commit 2e0273f into OpenTTD:master Feb 20, 2021
@FLHerne FLHerne deleted the flh-internal-register-error branch April 2, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frosch123 frosch123 frosch123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FLHerne @frosch123