Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysaml2: 5.0.0 -> 6.5.1, addressing CVE-2021-21238 & CVE-2021-21239 #111511

Merged
merged 1 commit into from Feb 2, 2021
Merged

pythonPackages.pysaml2: 5.0.0 -> 6.5.1, addressing CVE-2021-21238 & CVE-2021-21239 #111511

merged 1 commit into from Feb 2, 2021

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Jan 31, 2021

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2021-21238
https://nvd.nist.gov/vuln/detail/CVE-2021-21239

New version wants importlib-resources even on python 3.9 (yes, I know).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111511 run on x86_64-linux 1

4 packages built:
  • matrix-synapse
  • python37Packages.pysaml2
  • python38Packages.pysaml2
  • python39Packages.pysaml2

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 111511 run on x86_64-darwin 1

4 packages built:
  • matrix-synapse
  • python37Packages.pysaml2
  • python38Packages.pysaml2
  • python39Packages.pysaml2

@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 1, 2021
@risicle
Copy link
Contributor Author

risicle commented Feb 1, 2021

Re-tested nixpkgs-review, works.

@risicle
Copy link
Contributor Author

risicle commented Feb 1, 2021

Not sure what we're going to do about stable - the CVE-2021-21239 patch applies (and its tests pass), but I don't think getting the CVE-2021-21238 patch working is realistic.

@SuperSandro2000 SuperSandro2000 merged commit f37eee4 into NixOS:master Feb 2, 2021
@TredwellGit TredwellGit removed the 9.needs: port to stable A PR needs a backport to the stable release. label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@risicle @SuperSandro2000 @dotlambda @TredwellGit